Replaced deprecated @azure/monitor-query

[liranmauda]

Explain the Changes

Replaced deprecated @azure/monitor-query

Summary by CodeRabbit

• Chores
  • Updated Azure SDK dependencies to latest versions for improved stability and security.

[coderabbitai]

Walkthrough

Migrates Azure Monitor query dependency from @azure/monitor-query to @azure/monitor-query-logs, updates the corresponding imports in two source files, and bumps @azure/identity to version 4.13.0. No behavioral changes occur.

Changes

Cohort / File(s)	Summary
Dependency Migration package.json	Replaces @azure/monitor-query (1.3.3) with @azure/monitor-query-logs (1.0.0); updates @azure/identity from 4.12.0 to 4.13.0
Import Updates src/server/bg_services/replication_log_parser.js, src/server/system_services/account_server.js	Updates imports from @azure/monitor-query to @azure/monitor-query-logs; no implementation logic changes

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• Bumping deps to avoid CVE (21/09/2025) #9224: Also updates Azure monitoring dependencies (@azure/monitor-query and @azure/identity), indicating a broader Azure SDK upgrade effort.

Suggested reviewers

• nimrod-becker
• jackyalbo

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Replaced deprecated @azure/monitor-query' accurately summarizes the main change: replacing a deprecated Azure Monitor package with its successor.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9e7c4ad and 78003ba.

⛔ Files ignored due to path filters (1)

• package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (3)

• package.json (1 hunks)
• src/server/bg_services/replication_log_parser.js (1 hunks)
• src/server/system_services/account_server.js (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

• src/server/bg_services/replication_log_parser.js
• src/server/system_services/account_server.js
• package.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Build Noobaa Image
• GitHub Check: run-package-lock-validation
• GitHub Check: run-jest-unit-tests

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions:
   | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context.
   Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

.github/workflows/run-pr-tests.yaml (1)

119-119: Clarify the step ID to reflect its true purpose.

The step ID should_build_builder suggests this step decides whether to build, but it's actually a pull step. Consider renaming it to pull_builder_image (consistent with line 100's pull_base_image) to avoid confusion about its role in the workflow.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8da539a and 9e7c4ad.

📒 Files selected for processing (1)

• .github/workflows/run-pr-tests.yaml (2 hunks)

🧰 Additional context used

🧠 Learnings (2)

📚 Learning: 2025-06-19T11:03:49.934Z

Learnt from: nadavMiz
Repo: noobaa/noobaa-core PR: 9099
File: .github/workflows/run-pr-tests.yaml:135-136
Timestamp: 2025-06-19T11:03:49.934Z
Learning: In the noobaa-core project, the `make tester` command also calls `make noobaa` due to makefile target dependencies, so running `make tester` will build both the noobaa and tester images.

Applied to files:

• .github/workflows/run-pr-tests.yaml

📚 Learning: 2025-06-19T11:04:50.175Z

Learnt from: nadavMiz
Repo: noobaa/noobaa-core PR: 9099
File: .github/workflows/run-pr-tests.yaml:126-134
Timestamp: 2025-06-19T11:04:50.175Z
Learning: In make commands, the `-o` flag followed by a target name (e.g., `-o builder`) tells make to skip building that specific target, assuming it's already up to date. This is used in the noobaa-core project's workflow to skip building the builder image when it was successfully pulled from a registry.

Applied to files:

• .github/workflows/run-pr-tests.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Build Noobaa Image
• GitHub Check: run-jest-unit-tests
• GitHub Check: run-package-lock-validation

🔇 Additional comments (1)

.github/workflows/run-pr-tests.yaml (1)

101-102: Clarify whether this workflow optimization is intentional and document in PR description.

Verification confirms the conditionals were intentionally removed (not accidental). However, the change is entirely unrelated to the PR objective of replacing @azure/monitor-query, appearing only in this single commit with a generic message.

The workflow logic remains sound: when pulls fail, the build steps execute as fallback. The retry mechanism with historical date fallback mitigates risks for new branches where images don't exist in the registry.

To proceed, update the PR description to explicitly mention this workflow optimization and its rationale, or move it to a separate PR if it's unintended bundling with the dependency upgrade.