Skip to content

Commit 418bb3b

Browse files
Merge pull request #9286 from alphaprinz/notif_lifecycle_fixes_4469
notificatoins - fixes for lifecycle dfbugs 4469
2 parents 149c7f5 + 0bfe3c2 commit 418bb3b

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/server/object_services/object_server.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -986,7 +986,7 @@ async function delete_multiple_objects_by_filter(req) {
986986
let delete_results;
987987
let objects;
988988
// TODO: Add support to delete_objects_by_query also for versioning or add another function to support versioning.
989-
if (req.bucket.versioning === 'DISABLED' && config.DB_TYPE !== 'mongodb') /* only for postgres */ {
989+
if (req.bucket.versioning === 'DISABLED' && config.DB_TYPE !== 'mongodb' && reply_objects !== true) /* only for postgres */ {
990990
query.return_results = true; // we want to return the objects that were deleted
991991
objects = await MDStore.instance().delete_objects_by_query(query);
992992
} else {
@@ -1019,6 +1019,7 @@ async function delete_multiple_objects_by_filter(req) {
10191019
};
10201020
} else {
10211021
reply.deleted_objects[i] = get_object_info(objects[i]);
1022+
reply.deleted_objects[i].delete_marker = delete_results && delete_results[i] && delete_results[i].created_delete_marker;
10221023
}
10231024
}
10241025
}

src/util/notifications_util.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ function compose_notification_lifecycle(deleted_obj, notif_conf, bucket, object_
498498
const notif = compose_notification_base(notif_conf, bucket, {object_sdk});
499499

500500
notif.eventName = OP_TO_EVENT.lifecycle_delete.name + ':' +
501-
(deleted_obj.created_delete_marker ? 'DeleteMarkerCreated' : 'Delete');
501+
((deleted_obj.created_delete_marker || deleted_obj.delete_marker) ? 'DeleteMarkerCreated' : 'Delete');
502502
notif.s3.object.key = deleted_obj.key;
503503
notif.s3.object.size = deleted_obj.size;
504504
notif.s3.object.eTag = deleted_obj.etag;

0 commit comments

Comments
 (0)