chore: correct the remaining linting errors

jon-nfc · jon-nfc · commit f312563394a4 · 2025-06-13T19:24:31.000+09:30
ref: #5
diff --git a/.gitignore b/.gitignore
@@ -0,0 +1,2 @@
+# Temp Files
+*.tmp.*
diff --git a/manifests/alert-manager/base/kustomization.yaml b/manifests/alert-manager/base/kustomization.yaml
@@ -23,6 +23,7 @@ resources:
 
 
 patches:
+  # yamllint disable rule:indentation
   - target:
       kind: Alertmanager
       name: cluster
@@ -34,7 +35,7 @@ patches:
       - op: replace
         path: /spec/externalUrl
         value: alert-manager.local
-
+  # yamllint enable rule:indentation
 
 replacements:
   - source:
diff --git a/manifests/alert-manager/components/dashboard/GrafanaDashboard-AlertManager.yaml b/manifests/alert-manager/components/dashboard/GrafanaDashboard-AlertManager.yaml
@@ -14,4 +14,4 @@ spec:
       dashboards: grafana
   grafanaCom:
     id: 9578
-    revision: 4 # as @ 19-09-23
+    revision: 4     # as @ 19-09-23
diff --git a/manifests/alert-manager/components/ingress/kustomization.yaml b/manifests/alert-manager/components/ingress/kustomization.yaml
@@ -33,4 +33,3 @@ resources:
 #       kind: Ingress
 #       name: alert-manager
 #       version: v1
-
diff --git a/manifests/alert-manager/overlays/production/kustomization.yaml b/manifests/alert-manager/overlays/production/kustomization.yaml
@@ -16,6 +16,7 @@ labels:
 
 
 patches:
+  # yamllint disable rule:indentation
   - target:
       kind: Alertmanager
       name: cluster
@@ -27,6 +28,7 @@ patches:
       - op: replace
         path: /spec/externalUrl
         value: alert-manager.local
+  # yamllint enable rule:indentation
 
 #
 # Ingress Setup
diff --git a/manifests/gitlab-operator/base/kustomization.yaml b/manifests/gitlab-operator/base/kustomization.yaml
@@ -19,14 +19,10 @@ labels:
       app.kubernetes.io/part-of: gitlab-runner-operator
 
 
-# crds:
-#   # config/default/kustomization.yaml
-#   # - https://gitlab.com/gitlab-org/gl-openshift/gitlab-runner-operator//config/crd?ref=e8254fb99328edd9e78f6646e8abc2f7a42fdd96
-#   - https://gitlab.com/gitlab-org/gl-openshift/gitlab-runner-operator/-/raw/e8254fb99328edd9e78f6646e8abc2f7a42fdd96/config/crd/bases/apps.gitlab.com_runners.yaml
-
-
 images:
-  # image details fetched from https://gitlab.com/gitlab-org/gl-openshift/gitlab-runner-operator/-/releases using file `operator.k8s.yaml`
+  # image details fetched from 
+  # https://gitlab.com/gitlab-org/gl-openshift/gitlab-runner-operator/-/releases using file
+  # `operator.k8s.yaml`
   # config/manager/kustomization.tpl.yaml
   - name: controller
     newName: |-
@@ -64,6 +60,7 @@ patches:
       https://gitlab.com/gitlab-org/gl-openshift/gitlab-runner-operator/-/raw/160ee6bf2ad4e05d0e673d0652cc47bd6100ddec/config/manager/auth_proxy_patch.yaml
 
   # # Operator only has arch AMD64
+  # yamllint disable rule:indentation
   - patch: |-
       - op: replace
         path: /spec/template/spec/affinity
@@ -80,3 +77,4 @@ patches:
       kind: Deployment
       name: controller-manager
       version: v1
+      # yamllint enable rule:indentation
diff --git a/manifests/gitlab-operator/components/runner/ConfigMap.yaml b/manifests/gitlab-operator/components/runner/ConfigMap.yaml
@@ -6,6 +6,7 @@ metadata:
     app.kubernetes.io/component: ci-cd-runner
   name: gitlab-runner
 data:
+  # yamllint disable rule:indentation
   config.toml: |
     [[runners]]
 
@@ -37,3 +38,4 @@ data:
 
         [runners.kubernetes.node_tolerations]
           "CriticalAddonsOnly=true" = "NoExecute"
+  # yamllint enable rule:indentation
diff --git a/manifests/gitlab-operator/components/runner/Runner.yaml b/manifests/gitlab-operator/components/runner/Runner.yaml
@@ -17,7 +17,9 @@ spec:
   podSpec:
     - name: gitlab-runner
       patchType: merge
+      # yamllint disable rule:indentation
       patch: |
         securityContext:
           runAsNonRoot: false
+      # yamllint enable rule:indentation
   token: gitlab-runner-token
diff --git a/manifests/gitlab-operator/components/runner/kustomization.yaml b/manifests/gitlab-operator/components/runner/kustomization.yaml
@@ -14,6 +14,7 @@ patches:
   - target:
       kind: Runner
       name: gitlab-runner
+    # yamllint disable rule:indentation
     patch: |-
       # Runner Tags
       # - op: add
@@ -23,3 +24,4 @@ patches:
       - op: add
         path: /spec/runnerImage
         value: registry.gitlab.com/gitlab-org/gitlab-runner:v17.6.0
+    # yamllint enable rule:indentation
diff --git a/manifests/gitlab-operator/components/service-monitor/kustomization.yaml b/manifests/gitlab-operator/components/service-monitor/kustomization.yaml
@@ -37,7 +37,7 @@ replacements:
 
 
 patches:
-
+  # yamllint disable rule:indentation
   - patch: |-
       - op: remove
         path: /metadata/labels/app.kubernetes.io~1managed-by
@@ -48,6 +48,7 @@ patches:
           app.kubernetes.io/component: metrics
           app.kubernetes.io/name: prometheus
           app.kubernetes.io/part-of: gitlab-runner-operator
+    # yamllint enable rule:indentation
     target:
       kind: ServiceMonitor
       name: controller-manager-metrics-monitor
diff --git a/manifests/grafana-agent/base/ConfigMap-GrafanaAgent.yaml b/manifests/grafana-agent/base/ConfigMap-GrafanaAgent.yaml
@@ -6,6 +6,7 @@ metadata:
     app.kubernetes.io/component: exporter
   name: grafana-agent
 data:
+  # yamllint disable rule:indentation
   agent.yaml: |
     metrics:
       wal_directory: /tmp/wal
@@ -31,3 +32,4 @@ data:
         include_exporter_metrics: true
         enable_collectors:
           - uname
+  # yamllint enable rule:indentation
diff --git a/manifests/grafana-agent/base/Daemonset-GrafanaAgent.yaml b/manifests/grafana-agent/base/Daemonset-GrafanaAgent.yaml
@@ -31,7 +31,6 @@ spec:
             - --config.expand-env=true
           name: grafana-agent
           image: "grafana/agent:v0.43.4"
-          #imagePullPolicy: Never
           ports:
             - containerPort: 12345
               name: grafana-metrics
@@ -47,8 +46,6 @@ spec:
             capabilities:
               add:
                 - SYS_TIME
-              # drop:
-              # - ALL
             readOnlyRootFilesystem: false
             privileged: true
           volumeMounts:
diff --git a/manifests/grafana-agent/components/dashboard/GrafanaDashboard-node-exporter-full.yaml b/manifests/grafana-agent/components/dashboard/GrafanaDashboard-node-exporter-full.yaml
@@ -15,5 +15,4 @@ spec:
       dashboards: grafana
   grafanaCom:
     id: 1860
-    # revision: 32 # as @ 19-09-23
-    revision: 37 # as @ 11-01-25
+    revision: 37    # as @ 11-01-25
diff --git a/manifests/grafana-operator/base/kustomization.yaml b/manifests/grafana-operator/base/kustomization.yaml
@@ -57,7 +57,9 @@ patches:
       group: apiextensions.k8s.io
       version: v1
       kind: CustomResourceDefinition
+    # yamllint disable rule:indentation
     patch: |-
       - op: add
         path: /metadata/annotations/argocd.argoproj.io~1sync-options
         value: ServerSideApply=true
+    # yamllint enable rule:indentation
diff --git a/manifests/nfc-monitoring/overlays/production/kustomization.yaml b/manifests/nfc-monitoring/overlays/production/kustomization.yaml
@@ -14,6 +14,7 @@ patches:
   - target:
       kind: Alertmanager
       name: cluster
+    # yamllint disable rule:indentation
     patch: |-
       - op: replace
         path: /spec/version
@@ -22,10 +23,12 @@ patches:
       - op: replace
         path: /spec/externalUrl
         value: alert-manager.local
+    # yamllint enable rule:indentation
 
   - target:
       kind: Prometheus
       name: cluster
+    # yamllint disable rule:indentation
     patch: |-
       - op: replace
         path: /spec/version
@@ -38,6 +41,7 @@ patches:
             name: alertmanager-cluster
             namespace: alert
             port: web
+    # yamllint enable rule:indentation
 
 
 #
diff --git a/manifests/nginx/base/configmap-nginx.yaml b/manifests/nginx/base/configmap-nginx.yaml
@@ -8,6 +8,7 @@ metadata:
     app.kubernetes.io/part-of: nginx
   name: nginx
 data:
+  # yamllint disable rule:indentation
   default.conf: |
     server {
 
@@ -23,3 +24,4 @@ data:
 
             }
     }
+  # yamllint enable rule:indentation
diff --git a/manifests/nginx/components/gitlab_runner/kustomization.yaml b/manifests/nginx/components/gitlab_runner/kustomization.yaml
@@ -12,6 +12,7 @@ patches:
   - target:
       kind: Runner
       name: gitlab-runner
+    # yamllint disable rule:indentation
     patch: |-
       # Runner Tags
       # - op: add
@@ -21,3 +22,4 @@ patches:
       - op: add
         path: /spec/runnerImage
         value: registry.gitlab.com/gitlab-org/gitlab-runner:v17.6.0
+    # yamllint enable rule:indentation
diff --git a/manifests/nginx/components/gitlab_runner/runner-website.yaml b/manifests/nginx/components/gitlab_runner/runner-website.yaml
@@ -13,7 +13,9 @@ spec:
   podSpec:
     - name: gitlab-runner
       patchType: merge
+      # yamllint disable rule:indentation
       patch: |
         securityContext:
           runAsNonRoot: false
+      # yamllint enable rule:indentation
   token: token-secret-name
diff --git a/manifests/nginx/components/ingress/kustomization.yaml b/manifests/nginx/components/ingress/kustomization.yaml
@@ -8,7 +8,7 @@ resources:
   - ingress.yaml
 
 patches:
-
+  # yamllint disable rule:indentation
   - patch: |-
       - op: replace
         path: /metadata/annotations/cert-manager.io~1cluster-issuer
@@ -33,3 +33,4 @@ patches:
       kind: Ingress
       name: nginx
       version: v1
+      # yamllint enable rule:indentation
diff --git a/manifests/prometheus-operator/base/kustomization.yaml b/manifests/prometheus-operator/base/kustomization.yaml
@@ -48,6 +48,7 @@ replacements:
 
 
 patches:
+  # yamllint disable rule:indentation
   - patch: |-
       apiVersion: apiextensions.k8s.io/v1
       kind: CustomResourceDefinition
@@ -90,3 +91,4 @@ patches:
         annotations:
           argocd.argoproj.io/sync-options: ServerSideApply=true
         name: alertmanagers.monitoring.coreos.com
+  # yamllint enable rule:indentation
diff --git a/manifests/prometheus-operator/overlays/production/kustomization.yaml b/manifests/prometheus-operator/overlays/production/kustomization.yaml
@@ -7,9 +7,9 @@ kind: Kustomization
 namespace: operators
 
 images:
-    #
-    # Note; if you update the image, update the image within the patch
-    #
+  #
+  # Note; if you update the image, update the image within the patch
+  #
   - name: quay.io/prometheus-operator/prometheus-operator
     newTag: v0.79.2
 
@@ -21,7 +21,9 @@ patches:
   - target:
       kind: Deployment
       name: prometheus-operator
+    # yamllint disable rule:indentation
     patch: |-
       - op: replace
         path: /spec/template/spec/containers/0/args/1
         value: --prometheus-config-reloader=quay.io/prometheus-operator/prometheus-config-reloader:v0.79.2
+    # yamllint enable rule:indentation
diff --git a/manifests/prometheus/base/ClusterRoleBinding-prometheus-monitoring.yaml b/manifests/prometheus/base/ClusterRoleBinding-prometheus-monitoring.yaml
@@ -13,4 +13,3 @@ subjects:
   - kind: ServiceAccount
     name: prometheus
     namespace: default
-
diff --git a/manifests/prometheus/base/kustomization.yaml b/manifests/prometheus/base/kustomization.yaml
@@ -38,10 +38,12 @@ patches:
   - target:
       kind: Prometheus
       name: cluster
+    # yamllint disable rule:indentation
     patch: |-
       - op: replace
         path: /spec/version
         value: 2.47.0
+    # yamllint enable rule:indentation
 
 
 replacements:
diff --git a/manifests/prometheus/components/alertmanager/kustomization.yaml b/manifests/prometheus/components/alertmanager/kustomization.yaml
@@ -8,6 +8,7 @@ kind: Component
 
 
 patches:
+  # yamllint disable rule:indentation
   - patch: |-
       - op: replace
         path: /spec/alerting/alertmanagers
@@ -19,3 +20,4 @@ patches:
     target:
       kind: Prometheus
       name: cluster
+      # yamllint enable rule:indentation
diff --git a/manifests/prometheus/components/grafana-datasource/kustomization.yaml b/manifests/prometheus/components/grafana-datasource/kustomization.yaml
@@ -8,6 +8,7 @@ resources:
 
 
 patches:
+  # yamllint disable rule:indentation
   - patch: |-
       - op: replace
         path: /spec/datasource/url
@@ -16,3 +17,4 @@ patches:
     target:
       kind: GrafanaDatasource
       name: prometheus
+      # yamllint enable rule:indentation
diff --git a/manifests/prometheus/overlays/production/kustomization.yaml b/manifests/prometheus/overlays/production/kustomization.yaml
@@ -11,10 +11,12 @@ patches:
   - target:
       kind: Prometheus
       name: cluster
+    # yamllint disable rule:indentation
     patch: |-
       - op: replace
         path: /spec/version
         value: 2.47.0
+    # yamllint enable rule:indentation
 #
 # Ingress Setup
 #
