Don't emit warnings for unreadable or non-file package.json

Author: jasonkarns

libexec/nodenv-package-json-engine

@@ -23,10 +23,12 @@ package_json_has_precedence() {
 }
 
 find_package_json_path() {
-  root="$1"
+  local package_json root="$1"
   while [ -n "$root" ]; do
-    if [ -e "${root}/package.json" ]; then
-      echo "${root}/package.json"
+    package_json="$root/package.json"
+
+    if [ -r "$package_json" ] && [ -f "$package_json" ]; then
+      echo "$package_json"
       return
     fi
     root="${root%/*}"

test/nodenv-package-json-engine.bats

@@ -56,8 +56,35 @@ load test_helper
   assert_success "5.0.0 (set by NODENV_VERSION environment variable)"
 }
 
-@test 'Does not match babel preset env settings' {
-  cd_into_babel_env_package
+@test 'Does not match arbitrary "node" key in package.json' {
+  in_package_with_babel_env
+
+  run nodenv version-name
+
+  assert_success 'system'
+}
+
+@test 'Handles missing package.json' {
+  in_example_package
+
+  run nodenv version-name
+
+  assert_success 'system'
+}
+
+@test 'Does not fail with unreadable package.json' {
+  in_example_package
+  touch package.json
+  chmod -r package.json
+
+  run nodenv version-name
+
+  assert_success 'system'
+}
+
+@test 'Does not fail with non-file package.json' {
+  in_example_package
+  mkdir package.json
 
   run nodenv version-name
 

test/test_helper.bash

@@ -14,16 +14,23 @@ setup() {
   export PATH="$node_modules_bin:/usr/bin:/bin:/usr/sbin:/sbin"
 
   export NODENV_ROOT="$BATS_TEST_DIRNAME/fixtures/nodenv_root"
+
+
+  cd "$EXAMPLE_PACKAGE_DIR" || return 1
 }
 
 teardown() {
   rm -f "$EXAMPLE_PACKAGE_DIR"/.node-version
-  rm -f "$EXAMPLE_PACKAGE_DIR"/package.json
+  rm -rf "$EXAMPLE_PACKAGE_DIR"/package.json
   rm -f "$NODENV_ROOT/version"
 }
 
-in_package_for_engine() {
+in_example_package() {
   cd "$EXAMPLE_PACKAGE_DIR" || return 1
+}
+
+in_package_for_engine() {
+  in_example_package
   cat << JSON > package.json
 {
   "engines": {
@@ -33,8 +40,8 @@ in_package_for_engine() {
 JSON
 }
 
-cd_into_babel_env_package() {
-  cd "$EXAMPLE_PACKAGE_DIR" || return 1
+in_package_with_babel_env() {
+  in_example_package
   cat << JSON > package.json
 {
   "presets": [