chore: migrate to ESLint v9 and update deps (#902)

- Migrate to ESLint flat config
- Switch from `eslint-config-standard` to `neostandard` as the former
does not support ESLint v9 and seems to be unmaintained.
- Conform to the rules of the ESLint plugins/configs.
- Update all dependencies to their latest versions.

Author: VoltrexKeyva

.eslintignore

@@ -27,4 +27,6 @@ Promise.all(commandFiles.map(importCommand)).then((commands) => {
     .epilogue(epilogue)
     .help('help')
     .parse();
+}).catch((err) => {
+  throw err;
 });

.eslintrc

@@ -90,5 +90,6 @@ export function handler(argv) {
       if (status === false) {
         throw new Error(IGNORE);
       }
+      return undefined;
     }));
 }

bin/git-node.js

@@ -0,0 +1,46 @@
+import globals from 'globals';
+import pluginJs from '@eslint/js';
+import neostandard from 'neostandard';
+import nodePlugin from 'eslint-plugin-n';
+import pluginPromise from 'eslint-plugin-promise';
+import importPlugin from 'eslint-plugin-import';
+
+export default [
+  pluginJs.configs.recommended,
+  ...neostandard(),
+  nodePlugin.configs['flat/recommended'],
+  pluginPromise.configs['flat/recommended'],
+  importPlugin.flatConfigs.recommended,
+  {
+    ignores: [
+      '**/.git',
+      '**/.nyc_output',
+      'coverage/',
+      'node_modules/',
+      'lib/wpt/templates/',
+    ],
+  },
+  {
+    languageOptions: {
+      globals: globals.node,
+      sourceType: 'module',
+      ecmaVersion: 'latest',
+    },
+    rules: {
+      '@stylistic/semi': ['error', 'always'],
+      '@stylistic/space-before-function-paren': ['error', 'never'],
+      '@stylistic/no-multi-spaces': ['error', { ignoreEOLComments: true }],
+      camelcase: 'off',
+      '@stylistic/max-len': [
+        2,
+        100,
+        4,
+        { ignoreRegExpLiterals: true, ignoreUrls: true },
+      ],
+      '@stylistic/object-property-newline': 'off',
+      'promise/always-return': ['error', { ignoreLastCallback: true }],
+      'n/no-process-exit': 'off',
+      'n/no-unsupported-features/node-builtins': 'off',
+    },
+  },
+];

components/git/metadata.js

@@ -20,10 +20,10 @@ class Health {
   formatAsMarkdown() {
     const { success, pending, aborted, failed, unstable, count } = this;
     const rate = `${(success / (count - pending - aborted) * 100).toFixed(2)}%`;
-    // eslint-disable-next-line max-len
-    let result = '| UTC Time         | RUNNING | SUCCESS | UNSTABLE | ABORTED | FAILURE | Green Rate |\n';
-    // eslint-disable-next-line max-len
-    result += '| ---------------- | ------- | ------- | -------- | ------- | ------- | ---------- |\n';
+    let result =
+      '| UTC Time         | RUNNING | SUCCESS | UNSTABLE | ABORTED | FAILURE | Green Rate |\n';
+    result +=
+      '| ---------------- | ------- | ------- | -------- | ------- | ------- | ---------- |\n';
     const time = new Date().toISOString().slice(0, 16).replace('T', ' ');
     result += `| ${time} | ${pad(pending, 7)} | ${pad(success, 8)}|`;
     result += ` ${pad(unstable, 8)} | ${pad(aborted, 7)} | ${pad(failed, 7)} |`;

eslint.config.js

@@ -76,6 +76,8 @@ export class TestBuild extends Job {
         return result;
       }
     }
+
+    return undefined;
   }
 
   get commit() {

lib/ci/build-types/health_build.js

@@ -204,7 +204,6 @@ const FAILURE_FILTERS = [{
       context: { index: 0, contextBefore: 0, contextAfter: 0 }
     }, {
       pattern:
-        // eslint-disable-next-line max-len
         /error: Your local changes to the following files[\s\S]+Failed to merge in the changes./g,
       context: { index: 0, contextBefore: 0, contextAfter: 0 }
     }, {

lib/ci/build-types/test_build.js

@@ -81,6 +81,7 @@ export default class CLI {
       return defaultAnswer;
     }
 
+    // eslint-disable-next-line import/namespace -- Plugin can't validate computed reference here
     const answer = await inquirer[questionType]({
       message: question,
       default: defaultAnswer

lib/ci/ci_failure_parser.js

@@ -105,15 +105,13 @@ function parseCollaborators(readme, cli) {
 
   // We also assume that TSC & TSC Emeriti are also listed as collaborators
   CONTACT_RE.lastIndex = tscIndex;
-  // eslint-disable-next-line no-cond-assign
   while ((m = CONTACT_RE.exec(readme)) && CONTACT_RE.lastIndex < tscrIndex) {
     const login = m[1].toLowerCase();
     const user = new Collaborator(m[1], m[2], m[3], TSC);
     collaborators.set(login, user);
   }
 
   CONTACT_RE.lastIndex = clIndex;
-  // eslint-disable-next-line no-cond-assign
   while ((m = CONTACT_RE.exec(readme)) &&
     CONTACT_RE.lastIndex < cleIndex) {
     const login = m[1].toLowerCase();