Skip to content

Commit 6b5b042

Browse files
authored
chore: only enable nodeBuiltin globals for ESLint (#998)
Code is ESM, so we shouldn't enable CommonJS "globals".
1 parent 687217f commit 6b5b042

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

eslint.config.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,12 @@ export default [
1818
'coverage/',
1919
'node_modules/',
2020
'lib/wpt/templates/',
21+
'test/fixtures/release/*.js', // Copied from the nodejs/node repo
2122
],
2223
},
2324
{
2425
languageOptions: {
25-
globals: globals.node,
26+
globals: globals.nodeBuiltin,
2627
sourceType: 'module',
2728
ecmaVersion: 'latest',
2829
},

test/fixtures/release/expected-test-process-release.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
'use strict';
22

3-
// eslint-disable-next-line n/no-missing-require
43
require('../common');
54

65
const assert = require('assert');

test/fixtures/release/original-test-process-release.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
'use strict';
22

3-
// eslint-disable-next-line n/no-missing-require
43
require('../common');
54

65
const assert = require('assert');

0 commit comments

Comments
 (0)