chore: fixed grabbing agenda items and added more tests and hackmd parsing

Author: ovflowd

.github/workflows/create-meeting-artifacts-manual.yml

@@ -53,9 +53,7 @@ jobs:
         run: |
           meeting_group="${{ github.event.inputs.meeting_group }}"
           user=$(grep '^USER=' "templates/meeting_base_${meeting_group}" | cut -d'=' -f2 | xargs)
-          hackmd_team_name=$(grep '^HACKMD_TEAM_NAME=' "templates/meeting_base_${meeting_group}" | cut -d'=' -f2 | xargs)
           echo "user=$user" >> $GITHUB_OUTPUT
-          echo "hackmd_team_name=$hackmd_team_name" >> $GITHUB_OUTPUT
 
       - name: Create GitHub App Token
         uses: actions/create-github-app-token@67018539274d69449ef7c02e8e71183d1719ab42 # v2.1.4
@@ -69,7 +67,6 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ steps.app-token.outputs.token }}
           HACKMD_API_TOKEN: ${{ secrets.HACKMD_API_TOKEN }}
-          HACKMD_TEAM_NAME: ${{ steps.read-vars.outputs.hackmd_team_name }}
           GOOGLE_API_KEY: ${{ secrets.GOOGLE_API_KEY }}
         run: node create-node-meeting-artifacts.mjs ${{ github.event.inputs.meeting_group }}
 

.github/workflows/create-meeting-artifacts-scheduled.yml

@@ -51,9 +51,7 @@ jobs:
         run: |
           meeting_group="${{ matrix.meeting_group }}"
           user=$(grep '^USER=' "templates/meeting_base_${meeting_group}" | cut -d'=' -f2 | xargs)
-          hackmd_team_name=$(grep '^HACKMD_TEAM_NAME=' "templates/meeting_base_${meeting_group}" | cut -d'=' -f2 | xargs)
           echo "user=$user" >> $GITHUB_OUTPUT
-          echo "hackmd_team_name=$hackmd_team_name" >> $GITHUB_OUTPUT
 
       - name: Create GitHub App Token
         uses: actions/create-github-app-token@67018539274d69449ef7c02e8e71183d1719ab42 # v2.1.4
@@ -67,7 +65,6 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ steps.app-token.outputs.token }}
           HACKMD_API_TOKEN: ${{ secrets.HACKMD_API_TOKEN }}
-          HACKMD_TEAM_NAME: ${{ steps.read-vars.outputs.hackmd_team_name }}
           GOOGLE_API_KEY: ${{ secrets.GOOGLE_API_KEY }}
         run: node create-node-meeting-artifacts.mjs ${{ matrix.meeting_group }}
 

README.md

@@ -123,9 +123,14 @@ templates/minutes_base_<shortname>
 
 See [TEMPLATES_DOCUMENTATION.md](./TEMPLATES_DOCUMENTATION.md) for detailed template examples and variable explanations.
 
-### 2. Update GitHub Actions Workflow
+### 2. Update GitHub Actions Workflows
 
-Add your meeting group to `.github/workflows/create-meeting-artifacts.yml`:
+Add your meeting group to both workflow files:
+
+- `.github/workflows/create-meeting-artifacts-manual.yml`
+- `.github/workflows/create-meeting-artifacts-scheduled.yml`
+
+For manual workflow, add your group to the `options` list under `workflow_dispatch.inputs.meeting_group`:
 
 ```yaml
 workflow_dispatch:
@@ -142,6 +147,19 @@ workflow_dispatch:
         - your-new-group # Add your group here
 ```
 
+For scheduled workflow, add your group to the `matrix.meeting_group` list:
+
+```yaml
+strategy:
+  matrix:
+    meeting_group:
+      - uvwasi
+      - tsc
+      - build
+      # ... existing groups ...
+      - your-new-group # Add your group here
+```
+
 ### 3. Update Package.json Scripts
 
 Add npm scripts to `package.json` following this pattern:
@@ -211,10 +229,6 @@ The application creates:
 - `HACKMD_API_TOKEN`: HackMD API token for creating and managing documents
 - `GOOGLE_API_KEY`: Google Calendar API Key for read-only calendar access
 
-#### Optional
-
-- `HACKMD_TEAM_NAME`: HackMD team name/path for team workspaces
-
 ### Meeting Base Configuration
 
 Each `meeting_base_<group>` file contains:
@@ -227,5 +241,6 @@ REPO="repository-name"
 GROUP_NAME="Full Group Name"
 AGENDA_TAG="agenda-label"
 ISSUE_LABEL="optional-issue-label"
+HACKMD_TEAM_NAME="openjs-nodejs"
 JOINING_INSTRUCTIONS="Meeting join instructions"
 ```

create-node-meeting-artifacts.mjs

@@ -24,12 +24,12 @@ const calendarClient = google.createCalendarClient(config.google);
 // Step 3: Initialize GitHub client
 const githubClient = github.createGitHubClient(config);
 
-// Step 4: Initialize HackMD client
-const hackmdClient = hackmd.createHackMDClient(config);
-
-// Step 5: Read meeting configuration from templates
+// Step 4: Read meeting configuration from templates
 const meetingConfig = await meetings.readMeetingConfig(config);
 
+// Step 5: Initialize HackMD client with meeting configuration
+const hackmdClient = hackmd.createHackMDClient(config, meetingConfig);
+
 // Step 6: Find next meeting event in calendar
 const event = await google.findNextMeetingEvent(calendarClient, meetingConfig);
 

src/config.mjs

@@ -24,8 +24,6 @@ export const getConfig = () => ({
   hackmd: {
     // HackMD API token for authentication
     apiToken: process.env.HACKMD_API_TOKEN,
-    // HackMD team name
-    teamName: process.env.HACKMD_TEAM_NAME,
   },
 
   // Directory paths for templates, output, and configuration

src/github.mjs

@@ -59,24 +59,23 @@ export const getAgendaIssues = async (
 
   // Get all public repositories in the organization
   const repos = await paginate(rest.repos.listForOrg, {
-    org: properties.USER,
+    org: githubOrg,
     type: 'public',
     per_page: 100,
   });
 
-  // Fetch issues from all repositories concurrently
+  // Fetch issues and PRs from all repositories concurrently
   const issuePromises = repos.map(async repo => {
-    const issues = await paginate(rest.issues.listForRepo, {
+    const items = await paginate(rest.issues.listForRepo, {
       owner: githubOrg,
       repo: repo.name,
       labels: agendaTag,
       state: 'open',
       per_page: 100,
     });
 
-    const filteredIssues = issues.filter(({ pull_request }) => !pull_request); // Exclude PRs
-
-    return { repoName: repo.name, issues: filteredIssues };
+    // Include both issues and PRs for agenda items
+    return { repoName: repo.name, issues: items };
   });
 
   return Promise.all(issuePromises);

src/hackmd.mjs

@@ -5,10 +5,13 @@ import { HACKMD_DEFAULT_PERMISSIONS } from './constants.mjs';
 /**
  * Creates a HackMD API client
  * @param {import('./types.d.ts').AppConfig} config - Application configuration
+ * @param {import('./types.d.ts').MeetingConfig} meetingConfig - Meeting configuration
  * @returns {HackMDClient} Configured HackMD API client
  */
-export const createHackMDClient = ({ hackmd: { apiToken, teamName } }) => {
-  // Use team-specific API endpoint if teamPath is provided
+export const createHackMDClient = ({ hackmd: { apiToken } }, meetingConfig) => {
+  // Use team-specific API endpoint if teamName is provided in meeting config
+  const teamName = meetingConfig.properties.HACKMD_TEAM_NAME;
+
   const baseURL = teamName
     ? `https://api.hackmd.io/v1/teams/${teamName}`
     : 'https://api.hackmd.io/v1';

src/types.d.ts

@@ -28,8 +28,6 @@ export interface GoogleConfig {
 export interface HackMDConfig {
   /** HackMD API token */
   apiToken: string;
-  /** HackMD team name/path */
-  teamName?: string;
 }
 
 /**
@@ -74,6 +72,8 @@ export interface MeetingProperties {
   AGENDA_TAG?: string;
   /** Optional GitHub issue label */
   ISSUE_LABEL?: string;
+  /** HackMD team name for creating documents */
+  HACKMD_TEAM_NAME?: string;
   /** Meeting joining instructions */
   JOINING_INSTRUCTIONS?: string;
 }

templates/meeting_base_Release

@@ -1,9 +1,9 @@
 CALENDAR_FILTER="Node.js Release Working Group Meeting"
 CALENDAR_ID="c_16f0ae5d3a22625175d199dbdb1cac84c2d09eab7f173e94f558417cb5cdbfd8@group.calendar.google.com"
 USER="nodejs"
-HACKMD_TEAM_NAME="openjs-nodejs"
 REPO="Release"
 GROUP_NAME="Release WorkGroup"
+HACKMD_TEAM_NAME="openjs-nodejs"
 JOINING_INSTRUCTIONS="
 
 Join URL: <https://zoom.us/j/157618869>

templates/meeting_base_benchmarking

@@ -1,9 +1,9 @@
 CALENDAR_FILTER="Benchmarking WG Meeting"
 CALENDAR_ID="c_16f0ae5d3a22625175d199dbdb1cac84c2d09eab7f173e94f558417cb5cdbfd8@group.calendar.google.com"
 USER="nodejs"
-HACKMD_TEAM_NAME="openjs-nodejs"
 REPO="benchmarking"
 GROUP_NAME="Benchmarking WorkGroup"
+HACKMD_TEAM_NAME="openjs-nodejs"
 JOINING_INSTRUCTIONS="
 
 * link for participants: <https://zoom.us/j/345481302>