Merge pull request #93 from nodejs-monorepo-templates/fix-sane-fmt-file-listing

Fix sane-fmt touching file "within" symlinks

Author: KSXGitHub

tools/sane-fmt/index.js

@@ -1,26 +1,41 @@
 'use strict'
 const path = require('path')
 const fs = require('fs')
+const { spawnSync } = require('child_process')
 const process = require('process')
-const git = require('isomorphic-git')
-const { spawnSync } = require('exec-inline')
+const exec = require('exec-inline').spawnSync
 const command = require.resolve('@sane-fmt/wasm32-wasi/bin')
 const { project } = require('@tools/places')
 
 const argvPrefix = process.argv.slice(2)
 const TARGET_REGEX = /\.(js|ts)x?$/i
 
+function execCmd(command, args, options) {
+  const { error, status, stdout } = spawnSync(command, args, {
+    encoding: 'utf8',
+    stdio: ['pipe', 'pipe', 'inherit'],
+    ...options,
+  })
+
+  if (error) throw error
+  if (status) throw new Error(`Failed to execute ${command} ${args.join(' ')}`)
+
+  return stdout
+}
+
 async function listTargets() {
-  const fromLS = (await git.listFiles({ fs, dir: project }))
+  const fromLS = execCmd('git', ['ls-files'], { cwd: project })
+    .split('\n')
+    .map(line => line.trim())
+    .filter(Boolean)
     .filter(filename => TARGET_REGEX.test(filename))
 
-  const fromStatus = (
-    await git.statusMatrix({
-      fs,
-      dir: project,
-      filter: filename => TARGET_REGEX.test(filename),
-    })
-  ).map(([filename]) => filename)
+  const fromStatus = execCmd('git', ['status', '--porcelain=v1'], { cwd: project })
+    .split('\n')
+    .map(line => line.trim())
+    .filter(Boolean)
+    .map(line => line.slice(3))
+    .filter(filename => TARGET_REGEX.test(filename))
 
   return [...new Set([...fromLS, ...fromStatus])]
     .filter(filename => fs.existsSync(path.resolve(project, filename)))
@@ -33,7 +48,7 @@ async function createArgv() {
 
 async function execute() {
   const argv = await createArgv()
-  return spawnSync(process.execPath, command, ...argv).exit()
+  return exec(process.execPath, command, ...argv).exit()
 }
 
 module.exports = {

tools/sane-fmt/package.json

@@ -5,7 +5,6 @@
   "main": "index.js",
   "bin": "bin.js",
   "dependencies": {
-    "isomorphic-git": "^1.7.4",
     "@sane-fmt/wasm32-wasi": "^0.4.5",
     "exec-inline": "^0.0.5",
     "@tools/places": "file:../places"