All existing widgets have reached methods parity with that of their NodeGUI counterparts

Author: a7ul

src/components/Button/index.ts

@@ -4,8 +4,8 @@ import { ViewProps, setProps as setViewProps } from "../View";
 
 interface ButtonProps extends ViewProps {
   text?: string;
-  isFlat?: boolean;
-  icon?: string;
+  flat?: boolean;
+  icon?: QIcon;
 }
 
 const setProps = (
@@ -17,11 +17,10 @@ const setProps = (
     set text(buttonText: string) {
       widget.setText(buttonText);
     },
-    set isFlat(isFlat: boolean) {
+    set flat(isFlat: boolean) {
       widget.setFlat(isFlat);
     },
-    set icon(iconUrl: string) {
-      const icon = new QIcon(iconUrl);
+    set icon(icon: QIcon) {
       widget.setIcon(icon);
     }
   };

src/components/Image/ImageLabel.ts

@@ -4,10 +4,12 @@ export class ImageLabel extends QLabel {
   originalPixmap?: QPixmap;
   aspectRatioMode?: AspectRatioMode;
   setPixmap = (pixmap: QPixmap) => {
+    // react:✓
     super.setPixmap(pixmap);
     this.originalPixmap = pixmap;
   };
   setAspectRatioMode = (mode: AspectRatioMode) => {
+    // react:✓ TODO://getter
     this.aspectRatioMode = mode;
   };
   scalePixmap = (width: number, height: number) => {

src/components/PlainTextEdit/index.ts

@@ -1,11 +1,11 @@
-
 import { registerComponent } from "../config";
-import { QPlainTextEdit, QPlainTextEditEvents } from "@nodegui/nodegui";
+import { QPlainTextEdit } from "@nodegui/nodegui";
 import { ViewProps, setProps as setViewProps } from "../View";
 
 interface PlainTextEditProps extends ViewProps {
   children?: string;
   text?: string;
+  readOnly?: boolean;
 }
 
 const setProps = (
@@ -17,6 +17,9 @@ const setProps = (
     set text(text: string) {
       text ? widget.setPlainText(text) : widget.clear();
     },
+    set readOnly(isReadOnly: boolean) {
+      widget.setReadOnly(isReadOnly);
+    }
   };
   Object.assign(setter, newProps);
   setViewProps(widget, newProps, oldProps);

src/components/ProgressBar/index.ts

@@ -1,18 +1,32 @@
 import { registerComponent } from "../config";
-import { QProgressBar } from "@nodegui/nodegui";
+import { QProgressBar, Orientation } from "@nodegui/nodegui";
 import { ViewProps, setProps as setViewProps } from "../View";
 
-interface ProgressBarProps extends ViewProps {}
+interface ProgressBarProps extends ViewProps {
+  value?: number;
+  minimum?: number;
+  maximum?: number;
+  orientation?: Orientation;
+}
 
 const setProps = (
   widget: QProgressBar,
   newProps: ProgressBarProps,
   oldProps: ProgressBarProps
 ) => {
   const setter: ProgressBarProps = {
-    // set text(checkboxText: string) {
-    //   widget.setText(checkboxText);
-    // }
+    set value(val: number) {
+      widget.setValue(val);
+    },
+    set minimum(min: number) {
+      widget.setMinimum(min);
+    },
+    set maximum(max: number) {
+      widget.setMaximum(max);
+    },
+    set orientation(orientation: Orientation) {
+      widget.setOrientation(orientation);
+    }
   };
   Object.assign(setter, newProps);
   setViewProps(widget, newProps, oldProps);

src/index.ts

@@ -2,11 +2,11 @@ export { Renderer } from "./renderer";
 export { View } from "./components/View";
 export { Window } from "./components/Window";
 export { Text } from "./components/Text";
+export { Image } from "./components/Image";
 export { Button } from "./components/Button";
 export { CheckBox } from "./components/CheckBox";
 export { LineEdit } from "./components/LineEdit";
 export { PlainTextEdit } from "./components/PlainTextEdit";
 export { ProgressBar } from "./components/ProgressBar";
 export { RadioButton } from "./components/RadioButton";
-export { Image } from "./components/Image";
 export { useEventHandler } from "./hooks";