fix: address @effigies' review comments

Author: oesteban

nipype/utils/filemanip.py

@@ -60,7 +60,7 @@ def __init__(self, path):
 try:
     Path('/invented/file/path').resolve(strict=True)
 except TypeError:
-    from tempfile import gettempdir
+    from tempfile import TemporaryDirectory
 
     def _patch_resolve(self, strict=False):
         """Add the argument strict to signature in Python>3,<3.6."""
@@ -80,15 +80,15 @@ def _write_text(self, text):
         Path.write_text = _write_text
 
     try:
-        with tempfile.TemporaryDirectory() as tmpdir:
+        with TemporaryDirectory() as tmpdir:
             (Path(tmpdir) / 'exist_ok_test').mkdir(exist_ok=True)
     except TypeError:
         def _mkdir(self, mode=0o777, parents=False, exist_ok=False):
-            if not exist_ok and self.exists():
-                raise FileExistsError(str(self))
-            if not parents and not Path(str(self.parents)).exists():
-                raise FileNotFoundError(str(self.parents))
-            os.makedirs(str(self), mode=mode, exist_ok=exist_ok)
+            if parents:
+                os.makedirs(str(self), mode=mode, exist_ok=exist_ok)
+            elif not exist_ok or not self.exists():
+                os.mkdir(str(self), mode=mode)
+
         Path.mkdir = _mkdir
 
 except FileNotFoundError:

nipype/utils/tests/test_filemanip.py

@@ -601,8 +601,6 @@ def test_pickle(tmp_path, save_versioning):
 def test_Path(tmpdir):
     tmp_path = Path(tmpdir.strpath)
 
-    assert hasattr(tmp_path, 'write_text')
-
     (tmp_path / 'textfile').write_text('some text')
 
     with pytest.raises(OSError):