FIX: Always propagate existing Zenodo authors

Author: effigies

tools/update_zenodo.py

@@ -7,28 +7,8 @@
 from fuzzywuzzy import fuzz, process
 import subprocess as sp
 
-# These ORCIDs should go last
+# These names should go last
 CREATORS_LAST = ['Gorgolewski, Krzysztof J.', 'Ghosh, Satrajit']
-# for entries not found in line-contributions
-MISSING_ENTRIES = [
-    {"name": "Varada, Jan"},
-    {"name": "Schwabacher, Isaac"},
-    {"affiliation": "Child Mind Institute / Nathan Kline Institute",
-     "name": "Pellman, John",
-     "orcid": "0000-0001-6810-4461"},
-    {"name": "Khanuja, Ranjeet"},
-    {"affiliation":
-        "Medical Imaging & Biomarkers, Bioclinica, Newark, CA, USA.",
-     "name": "Pannetier, Nicolas",
-     "orcid": "0000-0002-0744-5155"},
-    {"name": "McDermottroe, Conor"},
-    {"affiliation":
-        "Max Planck Institute for Human Cognitive and Brain Sciences, "
-        "Leipzig, Germany.",
-     "name": "Mihai, Paul Glad",
-     "orcid": "0000-0001-5715-6442"},
-    {"name": "Lai, Jeff"}
-]
 
 if __name__ == '__main__':
     contrib_file = Path('line-contributors.txt')
@@ -55,21 +35,22 @@
     zenodo = json.loads(zenodo_file.read_text())
     zen_names = [' '.join(val['name'].split(',')[::-1]).strip()
                  for val in zenodo['creators']]
-    total_names = len(zen_names) + len(MISSING_ENTRIES)
+    total_names = len(zen_names)
 
     name_matches = []
     position = 1
     for ele in data:
         matches = process.extract(ele, zen_names, scorer=fuzz.token_sort_ratio,
                                   limit=2)
         # matches is a list [('First match', % Match), ('Second match', % Match)]
-        if matches[0][1] > 80:
-            val = zenodo['creators'][zen_names.index(matches[0][0])]
-        else:
+        if matches[0][1] <= 80:
             # skip unmatched names
             print("No entry to sort:", ele)
             continue
 
+        idx = zen_names.index(matches[0][0])
+        val = zenodo['creators'][idx]
+
         if val not in name_matches:
             if val['name'] not in CREATORS_LAST:
                 val['position'] = position
@@ -78,10 +59,11 @@
                 val['position'] = total_names + CREATORS_LAST.index(val['name'])
             name_matches.append(val)
 
-    for missing in MISSING_ENTRIES:
-        missing['position'] = position
-        position += 1
-        name_matches.append(missing)
+    for missing in zenodo['creators']:
+        if 'position' not in missing:
+            missing['position'] = position
+            position += 1
+            name_matches.append(missing)
 
     zenodo['creators'] = sorted(name_matches, key=lambda k: k['position'])
     # Remove position