fix: address failing tests, add tests for patched Path

Author: oesteban

nipype/pipeline/engine/utils.py

@@ -123,7 +123,7 @@ def write_node_report(node, result=None, is_mapnode=False):
 
     cwd = node.output_dir()
     report_file = Path(cwd) / '_report' / 'report.rst'
-    report_file.parent.mkdir(exist_ok=True)
+    report_file.parent.mkdir(exist_ok=True, parents=True)
 
     lines = [
         write_rst_header('Node: %s' % get_print_name(node), level=0),

nipype/utils/filemanip.py

@@ -60,6 +60,8 @@ def __init__(self, path):
 try:
     Path('/invented/file/path').resolve(strict=True)
 except TypeError:
+    from tempfile import gettempdir
+
     def _patch_resolve(self, strict=False):
         """Add the argument strict to signature in Python>3,<3.6."""
         resolved = Path().old_resolve() / self
@@ -70,6 +72,24 @@ def _patch_resolve(self, strict=False):
 
     Path.old_resolve = Path.resolve
     Path.resolve = _patch_resolve
+
+    if not hasattr(Path, 'write_text'):
+        def _write_text(self, text):
+            with open(str(self), 'w') as f:
+                f.write(text)
+        Path.write_text = _write_text
+
+    try:
+        (Path(gettempdir()) / 'exist_ok_test').mkdir(exist_ok=True)
+    except TypeError:
+        def _mkdir(self, mode=0o777, parents=False, exist_ok=False):
+            if not exist_ok and self.exists():
+                raise FileExistsError(str(self))
+            if not parents and not Path(str(self.parents)).exists():
+                raise FileNotFoundError(str(self.parents))
+            os.makedirs(str(self), mode=mode, exist_ok=exist_ok)
+        Path.mkdir = _mkdir
+
 except FileNotFoundError:
     pass
 except OSError:

nipype/utils/tests/test_filemanip.py

@@ -596,3 +596,21 @@ def test_pickle(tmp_path, save_versioning):
     savepkl(pickle_fname, testobj, versioning=save_versioning)
     outobj = loadpkl(pickle_fname)
     assert outobj == testobj
+
+
+def test_Path(tmpdir):
+    tmp_path = Path(tmpdir.strpath)
+
+    assert hasattr(tmp_path, 'write_text')
+
+    (tmp_path / 'textfile').write_text('some text')
+
+    with pytest.raises(OSError):
+        (tmp_path / 'no' / 'parents').mkdir(parents=False)
+
+    (tmp_path / 'no' / 'parents').mkdir(parents=True)
+
+    with pytest.raises(OSError):
+        (tmp_path / 'no' / 'parents').mkdir(parents=False)
+
+    (tmp_path / 'no' / 'parents').mkdir(parents=True, exist_ok=True)