Merge pull request #3709 from mauriliogenovese/fix/updatehash

fix: Resolve crashes when running workflows with updatehash=True

Author: effigies

nipype/pipeline/engine/nodes.py

@@ -452,7 +452,7 @@ def run(self, updatehash=False):
         cached, updated = self.is_cached()
 
         # If the node is cached, check on pklz files and finish
-        if not force_run and (updated or (not updated and updatehash)):
+        if cached and not force_run and (updated or updatehash):
             logger.debug("Only updating node hashes or skipping execution")
             inputs_file = op.join(outdir, "_inputs.pklz")
             if not op.exists(inputs_file):

nipype/pipeline/plugins/multiproc.py

@@ -336,8 +336,9 @@ def _send_procs_to_workers(self, updatehash=False, graph=None):
             if self._local_hash_check(jobid, graph):
                 continue
 
+            cached, updated = self.procs[jobid].is_cached()
             # updatehash and run_without_submitting are also run locally
-            if updatehash or self.procs[jobid].run_without_submitting:
+            if (cached and updatehash and not updated) or self.procs[jobid].run_without_submitting:
                 logger.debug("Running node %s on master thread", self.procs[jobid])
                 try:
                     self.procs[jobid].run(updatehash=updatehash)