STY: Apply ruff/flake8-bugbear rule B018

B018 Found useless expression. Either assign it to a variable or remove it.

Author: DimitriPapadopoulos

nipype/interfaces/ants/tests/test_resampling.py

@@ -103,4 +103,4 @@ def test_WarpTimeSeriesImageMultiTransform_invaffine_wrong(change_dir, create_wt
     wtsimt = create_wtsimt
     wtsimt.inputs.invert_affine = [0]
     with pytest.raises(Exception):
-        wtsimt.cmdline
+        wtsimt.cmdline  # noqa: B018

nipype/interfaces/ants/tests/test_segmentation.py

@@ -46,20 +46,20 @@ def test_LaplacianThickness_wrongargs(change_dir, create_lt):
     with pytest.raises(
         ValueError, match=r".* requires a value for input 'sulcus_prior' .*"
     ):
-        lt.cmdline
+        lt.cmdline  # noqa: B018
     lt.inputs.sulcus_prior = 0.15
     with pytest.raises(ValueError, match=r".* requires a value for input 'dT' .*"):
-        lt.cmdline
+        lt.cmdline  # noqa: B018
     lt.inputs.dT = 0.01
     with pytest.raises(
         ValueError, match=r".* requires a value for input 'prior_thickness' .*"
     ):
-        lt.cmdline
+        lt.cmdline  # noqa: B018
     lt.inputs.prior_thickness = 5.9
     with pytest.raises(
         ValueError, match=r".* requires a value for input 'smooth_param' .*"
     ):
-        lt.cmdline
+        lt.cmdline  # noqa: B018
     lt.inputs.smooth_param = 4.5
     assert (
         lt.cmdline == "LaplacianThickness functional.nii diffusion_weighted.nii "

nipype/interfaces/base/tests/test_specs.py

@@ -71,12 +71,12 @@ def test_TraitedSpec_dynamic():
     a.foo = 1
     assign_a = lambda: setattr(a, "foo", "a")
     with pytest.raises(Exception):
-        assign_a
+        assign_a()
     pkld_a = dumps(a)
     unpkld_a = loads(pkld_a)
     assign_a_again = lambda: setattr(unpkld_a, "foo", "a")
     with pytest.raises(Exception):
-        assign_a_again
+        assign_a_again()
 
 
 def test_DynamicTraitedSpec_tab_completion():
@@ -276,7 +276,7 @@ class TestCycle(nib.CommandLine):
     to0 = TestCycle()
     not_raised = True
     try:
-        to0.cmdline
+        to0.cmdline  # noqa: B018
     except nib.NipypeInterfaceError:
         not_raised = False
     assert not not_raised

nipype/interfaces/freesurfer/tests/test_preprocess.py

@@ -126,7 +126,7 @@ def test_mandatory_outvol(create_files_in_directory):
 
     # test raising error with mandatory args absent
     with pytest.raises(ValueError):
-        mni.cmdline
+        mni.cmdline  # noqa: B018
 
     # test with minimal args
     mni.inputs.in_file = filelist[0]
@@ -164,7 +164,7 @@ def test_bbregister(create_files_in_directory):
 
     # test raising error with mandatory args absent
     with pytest.raises(ValueError):
-        bbr.cmdline
+        bbr.cmdline  # noqa: B018
 
     bbr.inputs.subject_id = "fsaverage"
     bbr.inputs.source_file = filelist[0]
@@ -173,9 +173,9 @@ def test_bbregister(create_files_in_directory):
     # Check that 'init' is mandatory in FS < 6, but not in 6+
     if Info.looseversion() < LooseVersion("6.0.0"):
         with pytest.raises(ValueError):
-            bbr.cmdline
+            bbr.cmdline  # noqa: B018
     else:
-        bbr.cmdline
+        bbr.cmdline  # noqa: B018
 
     bbr.inputs.init = "fsl"
 

nipype/interfaces/fsl/tests/test_preprocess.py

@@ -229,11 +229,11 @@ def test_flirt(setup_flirt):
     flirter = fsl.FLIRT()
     # infile not specified
     with pytest.raises(ValueError):
-        flirter.cmdline
+        flirter.cmdline  # noqa: B018
     flirter.inputs.in_file = infile
     # reference not specified
     with pytest.raises(ValueError):
-        flirter.cmdline
+        flirter.cmdline  # noqa: B018
     flirter.inputs.reference = reffile
 
     # Generate outfile and outmatrix
@@ -253,7 +253,7 @@ def test_flirt(setup_flirt):
     axfm.inputs.apply_xfm = True
     # in_matrix_file or uses_qform must be defined
     with pytest.raises(RuntimeError):
-        axfm.cmdline
+        axfm.cmdline  # noqa: B018
     axfm2 = deepcopy(axfm)
     # test uses_qform
     axfm.inputs.uses_qform = True

tools/checkspecs.py

@@ -418,7 +418,7 @@ def _survives_exclude(self, matchstr, match_type):
             matchstr = matchstr[L:]
         for pat in patterns:
             try:
-                pat.search
+                pat.search  # noqa: B018
             except AttributeError:
                 pat = re.compile(pat)
             if pat.search(matchstr):