Apply suggestions from code review

Co-Authored-By: Oscar Esteban <code@oscaresteban.es>

Author: satra

nipype/algorithms/misc.py

@@ -822,7 +822,7 @@ def _run_interface(self, runtime):
         df = pd.DataFrame([input_dict])
 
         if self._have_lock:
-            self._lock = SoftFileLock(self.inputs.in_file + '.lock')
+            self._lock = SoftFileLock('%s.lock' % self.inputs.in_file)
 
             # Acquire lock
             self._lock.acquire()

nipype/external/cloghandler.py

@@ -158,7 +158,7 @@ def __init__(self,
         self.maxBytes = maxBytes
         self.backupCount = backupCount
         # Prevent multiple extensions on the lock file (Only handles the normal "*.log" case.)
-        self.lock_file = filename + '.lock'
+        self.lock_file = '%s.lock' % filename
         self.stream_lock = SoftFileLock(self.lock_file)
 
         # For debug mode, swap out the "_degrade()" method with a more a verbose one.

nipype/utils/config.py

@@ -209,7 +209,7 @@ def get_data(self, key):
         """Read options file"""
         if not os.path.exists(self.data_file):
             return None
-        with SoftFileLock(self.data_file + '.lock'):
+        with SoftFileLock('%s.lock' % self.data_file):
             with open(self.data_file, 'rt') as file:
                 datadict = load(file)
         if key in datadict:
@@ -220,14 +220,14 @@ def save_data(self, key, value):
         """Store config flie"""
         datadict = {}
         if os.path.exists(self.data_file):
-            with SoftFileLock(self.data_file + '.lock'):
+            with SoftFileLock('%s.lock' % self.data_file):
                 with open(self.data_file, 'rt') as file:
                     datadict = load(file)
         else:
             dirname = os.path.dirname(self.data_file)
             if not os.path.exists(dirname):
                 mkdir_p(dirname)
-        with SoftFileLock(self.data_file + '.lock'):
+        with SoftFileLock('%s.lock' % self.data_file):
             with open(self.data_file, 'wt') as file:
                 datadict[key] = value
                 dump(datadict, file)