STY: Apply ruff/flake8-simplify rule SIM103

SIM103 Return the condition directly

Author: DimitriPapadopoulos

nipype/interfaces/afni/base.py

@@ -326,6 +326,4 @@ def _cmd_prefix(self):
 
 def no_afni():
     """Check whether AFNI is not available."""
-    if Info.version() is None:
-        return True
-    return False
+    return Info.version() is None

nipype/interfaces/freesurfer/base.py

@@ -269,7 +269,4 @@ def no_freesurfer():
     used with skipif to skip tests that will
     fail if FreeSurfer is not installed"""
 
-    if Info.version() is None:
-        return True
-    else:
-        return False
+    return Info.version() is None

nipype/interfaces/fsl/base.py

@@ -262,10 +262,7 @@ def no_fsl():
     used with skipif to skip tests that will
     fail if FSL is not installed"""
 
-    if Info.version() is None:
-        return True
-    else:
-        return False
+    return Info.version() is None
 
 
 def no_fsl_course_data():

nipype/interfaces/spm/base.py

@@ -52,10 +52,7 @@ def func_is_3d(in_file):
     else:
         img = load(in_file)
         shape = img.shape
-        if len(shape) == 3 or (len(shape) == 4 and shape[3] == 1):
-            return True
-        else:
-            return False
+        return len(shape) == 3 or len(shape) == 4 and shape[3] == 1
 
 
 def get_first_3dfile(in_files):
@@ -254,10 +251,7 @@ def no_spm():
     used with pytest.mark.skipif decorator to skip tests
     that will fail if spm is not installed"""
 
-    if "NIPYPE_NO_MATLAB" in os.environ or Info.version() is None:
-        return True
-    else:
-        return False
+    return "NIPYPE_NO_MATLAB" in os.environ or Info.version() is None
 
 
 class SPMCommandInputSpec(BaseInterfaceInputSpec):

nipype/pipeline/plugins/condor.py

@@ -55,9 +55,7 @@ def _is_pending(self, taskid):
         iflogger.setLevel(logging.getLevelName("CRITICAL"))
         result = cmd.run(ignore_exception=True)
         iflogger.setLevel(oldlevel)
-        if result.runtime.stdout.count("\n%d" % taskid):
-            return True
-        return False
+        return bool(result.runtime.stdout.count("\n%d" % taskid))
 
     def _submit_batchtask(self, scriptfile, node):
         cmd = CommandLine(

nipype/pipeline/plugins/lsf.py

@@ -54,10 +54,9 @@ def _is_pending(self, taskid):
         result = cmd.run(ignore_exception=True)
         iflogger.setLevel(oldlevel)
         # logger.debug(result.runtime.stdout)
-        if "DONE" in result.runtime.stdout or "EXIT" in result.runtime.stdout:
-            return False
-        else:
-            return True
+        return (
+            "DONE" not in result.runtime.stdout and "EXIT" not in result.runtime.stdout
+        )
 
     def _submit_batchtask(self, scriptfile, node):
         cmd = CommandLine(

nipype/utils/misc.py

@@ -87,12 +87,7 @@ def is_container(item):
         True if container
         False if not (eg string)
     """
-    if isinstance(item, str):
-        return False
-    elif hasattr(item, "__iter__"):
-        return True
-    else:
-        return False
+    return not isinstance(item, str) and hasattr(item, "__iter__")
 
 
 def container_to_string(cont):