MNT: Remove volumeutils.BinOpener/allopen

Author: effigies

nibabel/tests/test_openers.py

@@ -23,7 +23,6 @@
                        DeterministicGzipFile,
                        )
 from ..tmpdirs import InTemporaryDirectory
-from ..volumeutils import BinOpener
 from ..optpkg import optional_package
 
 import unittest
@@ -114,11 +113,6 @@ def test_Opener_various():
                     assert fobj.fileno() != 0
 
 
-def test_BinOpener():
-    with pytest.raises(ExpiredDeprecationError):
-        BinOpener('test.txt', 'r')
-
-
 class MockIndexedGzipFile(GzipFile):
     def __init__(self, *args, **kwargs):
         self._drop_handles = kwargs.pop('drop_handles', False)

nibabel/tests/test_volumeutils.py

@@ -29,7 +29,6 @@
 from ..volumeutils import (array_from_file,
                            _is_compressed_fobj,
                            array_to_file,
-                           allopen,  # for backwards compatibility
                            fname_ext_ul_case,
                            write_zeros,
                            seek_tell,
@@ -49,7 +48,6 @@
 from ..openers import Opener, BZ2File
 from ..casting import (floor_log2, type_info, OK_FLOATS, shared_range)
 
-from ..deprecator import ExpiredDeprecationError
 from ..optpkg import optional_package
 
 from numpy.testing import (assert_array_almost_equal,
@@ -1042,13 +1040,6 @@ def test_fname_ext_ul_case():
         assert fname_ext_ul_case('afile.TxT') == 'afile.TxT'
 
 
-def test_allopen_deprecated():
-    # This import into volumeutils is for compatibility.  The code is the
-    # ``openers`` module.
-    with pytest.raises(ExpiredDeprecationError):
-        fobj = allopen(__file__)
-
-
 def test_shape_zoom_affine():
     shape = (3, 5, 7)
     zooms = (3, 2, 1)

nibabel/volumeutils.py

@@ -19,8 +19,7 @@
 import numpy as np
 
 from .casting import shared_range, OK_FLOATS
-from .openers import Opener, BZ2File, IndexedGzipFile
-from .deprecated import deprecate_with_version
+from .openers import BZ2File, IndexedGzipFile
 from .externals.oset import OrderedSet
 from .optpkg import optional_package
 
@@ -1337,17 +1336,6 @@ def rec2dict(rec):
     return dct
 
 
-class BinOpener(Opener):
-    """ Deprecated class that used to handle .mgz through specialized logic."""
-    __doc__ = Opener.__doc__
-
-    @deprecate_with_version('BinOpener class deprecated. '
-                            "Please use Opener class instead.",
-                            '2.1', '4.0')
-    def __init__(self, *args, **kwargs):
-        return super(BinOpener, self).__init__(*args, **kwargs)
-
-
 def fname_ext_ul_case(fname):
     """ `fname` with ext changed to upper / lower case if file exists
 
@@ -1378,21 +1366,3 @@ def fname_ext_ul_case(fname):
         if exists(mod_fname):
             return mod_fname
     return fname
-
-
-@deprecate_with_version('allopen is deprecated. '
-                        'Please use "Opener" class instead.',
-                        '2.0', '4.0')
-def allopen(fileish, *args, **kwargs):
-    """ Compatibility wrapper for old ``allopen`` function
-
-    Wraps creation of ``Opener`` instance, while picking up module global
-    ``default_compresslevel``.
-
-    Please see docstring of ``Opener`` for details.
-    """
-
-    class MyOpener(Opener):
-        default_compresslevel = default_compresslevel
-
-    return MyOpener(fileish, *args, **kwargs)