FIX: Check status code for from_url

Author: effigies

nibabel/cifti2/tests/test_caretspec.py

@@ -0,0 +1,18 @@
+from pathlib import Path
+
+from nibabel.cifti2.caretspec import *
+
+from nibabel.testing import data_path
+
+
+def test_CaretSpecFile():
+    fsLR = CaretSpecFile.from_filename(Path(data_path) / "fsLR.wb.spec")
+
+    assert fsLR.metadata == {}
+    assert fsLR.version == "1.0"
+    assert len(fsLR.data_files) == 5
+
+    for df in fsLR.data_files:
+        assert isinstance(df, CaretSpecDataFile)
+        if df.data_file_type == 'SURFACE':
+            assert isinstance(df, SurfaceDataFile)

nibabel/filebasedimages.py

@@ -576,11 +576,13 @@ def to_bytes(self, **kwargs):
         return bio.getvalue()
 
     @classmethod
-    def from_url(klass, url):
+    def from_url(klass, url, timeout=5):
         """ Fetch image from remote location and construct an image
 
         Requires the ``requests`` library to be installed.
         """
         import requests
-        res = requests.get(url)
+        res = requests.get(url, timeout=timeout)
+        if not res.ok:
+            raise IOError(f"[Error {res.status_code}] Could not retrieve {url}")
         return klass.from_bytes(res.content)