Address more comments, add a test case for 4d float64 data.

Author: Robert D. Vincent

nibabel/minc1.py

@@ -95,7 +95,8 @@ def get_data_shape(self):
     def get_zooms(self):
         """ Get real-world sizes of voxels """
         # zooms must be positive; but steps in MINC can be negative
-        return tuple([abs(float(dim.step)) if hasattr(dim, 'step') else 1.0 for dim in self._dims])
+        return tuple([abs(float(dim.step)) if hasattr(dim, 'step') else 1.0
+                      for dim in self._dims])
 
     def get_affine(self):
         nspatial = len(self._spatial_dims)

nibabel/minc2.py

@@ -77,6 +77,9 @@ def _get_dimensions(self, var):
             dimorder = var.attrs['dimorder'].decode()
         except KeyError:  # No specified dimensions
             return []
+        # The dimension name list must contain only as many entries
+        # as the variable has dimensions. This reduces errors when an
+        # unnecessary dimorder attribute is left behind.
         return dimorder.split(',')[:len(var.shape)]
 
     def get_data_dtype(self):

nibabel/tests/data/minc2-4d-d.mnc

@@ -88,6 +88,21 @@
             max=0.74901961,
             mean=0.6061103),
         is_proxy=True),
+    dict(
+        fname=pjoin(data_path, 'minc2-4d-d.mnc'),
+        shape=(5, 16, 16, 16),
+        dtype=np.float64,
+        affine=np.array([[1., 0., 0.,  -6.96 ],
+                         [0., 1., 0., -12.453],
+                         [0., 0., 1.,  -9.48 ],
+                         [0., 0., 0., 1.]]),
+        zooms=(1., 1., 1., 1.),
+        # These values from mincstats
+        data_summary=dict(
+            min=0.0,
+            max=5.0,
+            mean=2.00078125),
+        is_proxy=True),
 ]
 
 if have_h5py: