ENH: Switch from predicate/and/or to if/predicate/else

Author: effigies

nibabel/cmdline/dicomfs.py

@@ -231,7 +231,7 @@ def main(args=None):
 
     if opts.verbose:
         logger.addHandler(logging.StreamHandler(sys.stdout))
-        logger.setLevel(opts.verbose > 1 and logging.DEBUG or logging.INFO)
+        logger.setLevel(logging.DEBUG if opts.verbose > 1 else logging.INFO)
 
     if len(files) != 2:
         sys.stderr.write(f'Please provide two arguments:\n{parser.usage}\n')

nibabel/tests/test_nifti1.py

@@ -538,7 +538,7 @@ def test_slice_times(self):
         hdr.set_slice_duration(0.1)
         # We need a function to print out the Nones and floating point
         # values in a predictable way, for the tests below.
-        _stringer = lambda val: val is not None and f'{val:2.1f}' or None
+        _stringer = lambda val: f'{val:2.1f}' if val is not None else None
         _print_me = lambda s: list(map(_stringer, s))
         # The following examples are from the nifti1.h documentation.
         hdr['slice_code'] = slice_order_codes['sequential increasing']

nibabel/volumeutils.py

@@ -35,8 +35,8 @@
     DT = ty.TypeVar('DT', bound=np.generic)
 
 sys_is_le = sys.byteorder == 'little'
-native_code = sys_is_le and '<' or '>'
-swapped_code = sys_is_le and '>' or '<'
+native_code = '<' if sys_is_le else '>'
+swapped_code = '>' if sys_is_le else '<'
 
 _endian_codes = (  # numpy code, aliases
     ('<', 'little', 'l', 'le', 'L', 'LE'),