Merge pull request #1186 from effigies/ci/fix_archive

CI: Cache git-archive separately from Python packages

Author: effigies

.github/workflows/stable.yml

@@ -46,11 +46,17 @@ jobs:
         run: python -m build
       - run: twine check dist/*
       - name: Build git archive
-        run: git archive -v -o dist/nibabel-archive.tgz HEAD
-      - uses: actions/upload-artifact@v3
+        run: mkdir archive && git archive -v -o archive/nibabel-archive.tgz HEAD
+      - name: Upload sdist and wheel artifacts
+        uses: actions/upload-artifact@v3
         with:
           name: dist
           path: dist/
+      - name: Upload git archive artifact
+        uses: actions/upload-artifact@v3
+        with:
+          name: archive
+          path: archive/
 
   test-package:
     runs-on: ubuntu-latest
@@ -59,10 +65,18 @@ jobs:
       matrix:
         package: ['wheel', 'sdist', 'archive']
     steps:
-      - uses: actions/download-artifact@v3
+      - name: Download sdist and wheel artifacts
+        if: matrix.package != 'archive'
+        uses: actions/download-artifact@v3
         with:
           name: dist
           path: dist/
+      - name: Download git archive artifact
+        if: matrix.package == 'archive'
+        uses: actions/download-artifact@v3
+        with:
+          name: archive
+          path: archive/
       - uses: actions/setup-python@v4
         with:
           python-version: 3
@@ -71,14 +85,14 @@ jobs:
       - name: Update pip
         run: pip install --upgrade pip
       - name: Install wheel
-        run: pip install dist/nibabel-*.whl
         if: matrix.package == 'wheel'
+        run: pip install dist/nibabel-*.whl
       - name: Install sdist
-        run: pip install dist/nibabel-*.tar.gz
         if: matrix.package == 'sdist'
+        run: pip install dist/nibabel-*.tar.gz
       - name: Install archive
-        run: pip install dist/nibabel-archive.tgz
         if: matrix.package == 'archive'
+        run: pip install archive/nibabel-archive.tgz
       - run: python -c 'import nibabel; print(nibabel.__version__)'
       - name: Install test extras
         run: pip install nibabel[test]
@@ -165,17 +179,17 @@ jobs:
       - name: Install NiBabel
         run: tools/ci/install.sh
       - name: Run tests
-        run: tools/ci/check.sh
         if: ${{ matrix.check != 'skiptests' }}
+        run: tools/ci/check.sh
       - name: Submit coverage
-        run: tools/ci/submit_coverage.sh
         if: ${{ always() }}
+        run: tools/ci/submit_coverage.sh
       - name: Upload pytest test results
+        if: ${{ always() && matrix.check == 'test' }}
         uses: actions/upload-artifact@v3
         with:
           name: pytest-results-${{ matrix.os }}-${{ matrix.python-version }}
           path: for_testing/test-results.xml
-        if: ${{ always() && matrix.check == 'test' }}
 
   publish:
     runs-on: ubuntu-latest