enh: move cifti intent check into to_file_map

Author: mgxd

nibabel/cifti2/cifti2.py

@@ -1384,6 +1384,8 @@ def to_file_map(self, file_map=None):
         header = self._nifti_header
         extension = Cifti2Extension(content=self.header.to_xml())
         header.extensions.append(extension)
+        if header.get_intent()[0] == 'none':
+            raise ValueError("CIFTI image has an invalid intent code.")
         data = reshape_dataobj(self.dataobj,
                                (1, 1, 1, 1) + self.dataobj.shape)
         # If qform not set, reset pixdim values so Nifti2 does not complain
@@ -1442,6 +1444,4 @@ def save(img, filename):
     filename : str
         filename to which to save image
     """
-    if img.nifti_header.get_intent()[0] == 'none':
-        raise ValueError("CIFTI image has an invalid intent code.")
     Cifti2Image.instance_to_filename(img, filename)

nibabel/cifti2/tests/test_new_cifti2.py

@@ -12,7 +12,7 @@
 from nibabel import cifti2 as ci
 from nibabel.tmpdirs import InTemporaryDirectory
 
-from nose.tools import assert_true, assert_equal
+from nose.tools import assert_true, assert_equal, assert_raises
 
 affine = [[-1.5, 0, 0, 90],
           [0, 1.5, 0, -85],
@@ -213,6 +213,8 @@ def test_dtseries():
     hdr = ci.Cifti2Header(matrix)
     data = np.random.randn(13, 9)
     img = ci.Cifti2Image(data, hdr)
+    with assert_raises(ValueError):
+        img.to_filename('test.dtseries.nii')
     img.nifti_header.set_intent('NIFTI_INTENT_CONNECTIVITY_DENSE_SERIES')
 
     with InTemporaryDirectory():
@@ -234,6 +236,8 @@ def test_dscalar():
     hdr = ci.Cifti2Header(matrix)
     data = np.random.randn(2, 9)
     img = ci.Cifti2Image(data, hdr)
+    with assert_raises(ValueError):
+        nib.save(img, 'test.dscalar.nii')
     img.nifti_header.set_intent('NIFTI_INTENT_CONNECTIVITY_DENSE_SCALARS')
 
     with InTemporaryDirectory():
@@ -255,6 +259,8 @@ def test_dlabel():
     hdr = ci.Cifti2Header(matrix)
     data = np.random.randn(2, 9)
     img = ci.Cifti2Image(data, hdr)
+    with assert_raises(ValueError):
+        ci.save(img, 'test.dlabel.nii')
     img.nifti_header.set_intent('NIFTI_INTENT_CONNECTIVITY_DENSE_LABELS')
 
     with InTemporaryDirectory():
@@ -379,7 +385,7 @@ def test_plabel():
     matrix.append(parcel_map)
     hdr = ci.Cifti2Header(matrix)
     data = np.random.randn(2, 3)
-    img = ci.Cifti2Image(data, hdr
+    img = ci.Cifti2Image(data, hdr)
     img.nifti_header.set_intent('NIFTI_INTENT_CONNECTIVITY_UNKNOWN')
 
     with InTemporaryDirectory():