TEST: Use tmp_path and explicit delete to appease Windows tempdir cleanup

Author: effigies

nibabel/tests/test_openers.py

@@ -127,35 +127,36 @@ def patch_indexed_gzip(state):
         yield
 
 
-def test_Opener_gzip_type():
-    # Test that BufferedGzipFile or IndexedGzipFile are used as appropriate
-
-    data = 'this is some test data'
-    fname = 'test.gz'
-
-    with InTemporaryDirectory():
-
-        # make some test data
-        with GzipFile(fname, mode='wb') as f:
-            f.write(data.encode())
-
-        # Each test is specified by a tuple containing:
-        #   (indexed_gzip present, Opener kwargs, expected file type)
-        tests = [
-            (False, {'mode': 'rb', 'keep_open': True}, GzipFile),
-            (False, {'mode': 'rb', 'keep_open': False}, GzipFile),
-            (False, {'mode': 'wb', 'keep_open': True}, GzipFile),
-            (False, {'mode': 'wb', 'keep_open': False}, GzipFile),
-            (True, {'mode': 'rb', 'keep_open': True}, MockIndexedGzipFile),
-            (True, {'mode': 'rb', 'keep_open': False}, MockIndexedGzipFile),
-            (True, {'mode': 'wb', 'keep_open': True}, GzipFile),
-            (True, {'mode': 'wb', 'keep_open': False}, GzipFile),
-        ]
-
-        for test in tests:
-            igzip_present, kwargs, expected = test
-            with patch_indexed_gzip(igzip_present):
-                assert isinstance(Opener(fname, **kwargs).fobj, expected)
+def test_Opener_gzip_type(tmp_path):
+    # Test that GzipFile or IndexedGzipFile are used as appropriate
+
+    data = b'this is some test data'
+    fname = tmp_path / 'test.gz'
+
+    # make some test data
+    with GzipFile(fname, mode='wb') as f:
+        f.write(data)
+
+    # Each test is specified by a tuple containing:
+    #   (indexed_gzip present, Opener kwargs, expected file type)
+    tests = [
+        (False, {'mode': 'rb', 'keep_open': True}, GzipFile),
+        (False, {'mode': 'rb', 'keep_open': False}, GzipFile),
+        (False, {'mode': 'wb', 'keep_open': True}, GzipFile),
+        (False, {'mode': 'wb', 'keep_open': False}, GzipFile),
+        (True, {'mode': 'rb', 'keep_open': True}, MockIndexedGzipFile),
+        (True, {'mode': 'rb', 'keep_open': False}, MockIndexedGzipFile),
+        (True, {'mode': 'wb', 'keep_open': True}, GzipFile),
+        (True, {'mode': 'wb', 'keep_open': False}, GzipFile),
+    ]
+
+    for test in tests:
+        igzip_present, kwargs, expected = test
+        with patch_indexed_gzip(igzip_present):
+            opener = Opener(fname, **kwargs)
+            assert isinstance(opener.fobj, expected)
+            # Explicit close to appease Windows
+            del opener
 
 
 class TestImageOpener(unittest.TestCase):