RF: Avoid validation when testing CIFTI saving

Author: mgxd

nibabel/cifti2/tests/test_cifti2.py

@@ -426,3 +426,18 @@ def make_imaker(self, arr, header=None, ni_header=None):
             )
             header.matrix.append(mim)
         return lambda: self.image_maker(arr.copy(), header, ni_header)
+
+    def validate_filenames(self, imaker, params, validate=False):
+        super().validate_filenames(imaker, params, validate=validate)
+
+    def validate_mmap_parameter(self, imaker, params, validate=False):
+        super().validate_mmap_parameter(imaker, params, validate=validate)
+
+    def validate_to_bytes(self, imaker, params, validate=False):
+        super().validate_to_bytes(imaker, params, validate=validate)
+
+    def validate_from_bytes(self, imaker, params, validate=False):
+        super().validate_from_bytes(imaker, params, validate=validate)
+
+    def validate_to_from_bytes(self, imaker, params, validate=False):
+        super().validate_to_from_bytes(imaker, params, validate=validate)

nibabel/cifti2/tests/test_cifti2io_axes.py

@@ -91,7 +91,7 @@ def check_rewrite(arr, axes, extension='.nii'):
         custom extension to use
     """
     (fd, name) = tempfile.mkstemp(extension)
-    cifti2.Cifti2Image(arr, header=axes).to_filename(name)
+    cifti2.Cifti2Image(arr, header=axes).to_filename(name, validate=False)
     img = nib.load(name)
     arr2 = img.get_fdata()
     assert np.allclose(arr, arr2)

nibabel/cifti2/tests/test_new_cifti2.py

@@ -406,7 +406,7 @@ def test_plabel():
     img = ci.Cifti2Image(data, hdr)
 
     with InTemporaryDirectory():
-        ci.save(img, 'test.plabel.nii')
+        ci.save(img, 'test.plabel.nii', validate=False)
         img2 = ci.load('test.plabel.nii')
         assert img.nifti_header.get_intent()[0] == 'ConnUnknown'
         assert isinstance(img2, ci.Cifti2Image)

nibabel/tests/test_image_api.py

@@ -118,7 +118,7 @@ def validate_header_deprecated(self, imaker, params):
             hdr = img.get_header()
         assert hdr is img.header
 
-    def validate_filenames(self, imaker, params):
+    def validate_filenames(self, imaker, params, **kwargs):
         # Validate the filename, file_map interface
 
         if not self.can_save:
@@ -155,7 +155,7 @@ def validate_filenames(self, imaker, params):
                   warnings.filterwarnings('error',
                                           category=DeprecationWarning,
                                           module=r"nibabel.*")
-                  img.to_filename(path)
+                  img.to_filename(path, **kwargs)
                   rt_img = img.__class__.from_filename(path)
               assert_array_equal(img.shape, rt_img.shape)
               assert_almost_equal(img.get_fdata(), rt_img.get_fdata())
@@ -433,7 +433,7 @@ def validate_shape_deprecated(self, imaker, params):
         with pytest.raises(ExpiredDeprecationError):
             img.get_shape()
 
-    def validate_mmap_parameter(self, imaker, params):
+    def validate_mmap_parameter(self, imaker, params, **kwargs):
         img = imaker()
         fname = img.get_filename()
         with InTemporaryDirectory():
@@ -445,7 +445,7 @@ def validate_mmap_parameter(self, imaker, params):
                 if not img.rw or not img.valid_exts:
                     return
                 fname = 'image' + img.valid_exts[0]
-                img.to_filename(fname)
+                img.to_filename(fname, **kwargs)
             rt_img = img.__class__.from_filename(fname, mmap=True)
             assert_almost_equal(img.get_fdata(), rt_img.get_fdata())
             rt_img = img.__class__.from_filename(fname, mmap=False)
@@ -510,22 +510,22 @@ def validate_affine_deprecated(self, imaker, params):
 
 
 class SerializeMixin(object):
-    def validate_to_bytes(self, imaker, params):
+    def validate_to_bytes(self, imaker, params, **kwargs):
         img = imaker()
         serialized = img.to_bytes()
         with InTemporaryDirectory():
             fname = 'img' + self.standard_extension
-            img.to_filename(fname)
+            img.to_filename(fname, **kwargs)
             with open(fname, 'rb') as fobj:
                 file_contents = fobj.read()
         assert serialized == file_contents
 
-    def validate_from_bytes(self, imaker, params):
+    def validate_from_bytes(self, imaker, params, **kwargs):
         img = imaker()
         klass = getattr(self, 'klass', img.__class__)
         with InTemporaryDirectory():
             fname = 'img' + self.standard_extension
-            img.to_filename(fname)
+            img.to_filename(fname, **kwargs)
 
             all_images = list(getattr(self, 'example_images', [])) + [{'fname': fname}]
             for img_params in all_images:
@@ -538,12 +538,12 @@ def validate_from_bytes(self, imaker, params):
                 del img_a
                 del img_b
 
-    def validate_to_from_bytes(self, imaker, params):
+    def validate_to_from_bytes(self, imaker, params, **kwargs):
         img = imaker()
         klass = getattr(self, 'klass', img.__class__)
         with InTemporaryDirectory():
             fname = 'img' + self.standard_extension
-            img.to_filename(fname)
+            img.to_filename(fname, **kwargs)
 
             all_images = list(getattr(self, 'example_images', [])) + [{'fname': fname}]
             for img_params in all_images: