TEST: Catch warnings in clear_and_catch tests

Author: effigies

nibabel/tests/test_testing.py

@@ -64,7 +64,7 @@ def test_assert_allclose_safely():
 
 def assert_warn_len_equal(mod, n_in_context):
     mod_warns = mod.__warningregistry__
-    # Python 3.4 appears to clear any pre-existing warnings of the same type,
+    # Python 3 appears to clear any pre-existing warnings of the same type,
     # when raising warnings inside a catch_warnings block. So, there is a
     # warning generated by the tests within the context manager, but no
     # previous warnings.
@@ -84,18 +84,15 @@ def test_clear_and_catch_warnings():
     assert_equal(my_mod.__warningregistry__, {})
     # Without specified modules, don't clear warnings during context
     with clear_and_catch_warnings():
-        warnings.simplefilter('ignore')
         warnings.warn('Some warning')
     assert_warn_len_equal(my_mod, 1)
     # Confirm that specifying module keeps old warning, does not add new
     with clear_and_catch_warnings(modules=[my_mod]):
-        warnings.simplefilter('ignore')
         warnings.warn('Another warning')
     assert_warn_len_equal(my_mod, 1)
     # Another warning, no module spec does add to warnings dict, except on
-    # Python 3.4 (see comments in `assert_warn_len_equal`)
+    # Python 3 (see comments in `assert_warn_len_equal`)
     with clear_and_catch_warnings():
-        warnings.simplefilter('ignore')
         warnings.warn('Another warning')
     assert_warn_len_equal(my_mod, 2)