TEST: Drop BZ2 mio error checks (Python 3.3 only)

Author: effigies

nibabel/tests/test_analyze.py

@@ -698,8 +698,6 @@ class TestAnalyzeImage(tsi.TestSpatialImage, tsi.MmapImageMixin):
     image_class = AnalyzeImage
     can_save = True
     supported_np_types = TestAnalyzeHeader.supported_np_types
-    # Flag to skip bz2 save tests if they are going to break
-    bad_bz2 = False
 
     def test_supported_types(self):
         img = self.image_class(np.zeros((2, 3, 4)), np.eye(4))
@@ -794,9 +792,7 @@ def test_big_offset_exts(self):
         arr = np.arange(24, dtype=np.int16).reshape((2, 3, 4))
         aff = np.eye(4)
         img_ext = img_klass.files_types[0][1]
-        compressed_exts = ['', '.gz']
-        if not self.bad_bz2:
-            compressed_exts.append('.bz2')
+        compressed_exts = ['', '.gz', '.bz2']
         with InTemporaryDirectory():
             for offset in (0, 2048):
                 # Set offset in in-memory image

nibabel/tests/test_helpers.py

@@ -31,33 +31,6 @@ def bytesio_round_trip(img):
     return klass.from_file_map(bytes_map)
 
 
-def bz2_mio_error():
-    """ Return True if writing mat 4 file fails
-
-    Writing an empty string can fail for bz2 objects in python 3.3:
-
-    https://bugs.python.org/issue16828
-
-    This in turn causes scipy to give this error when trying to write bz2 mat
-    files.
-
-    This won't cause a problem for scipy releases after Jan 24 2014 because of
-    commit 98ef522d99 (in scipy)
-    """
-    if not have_scipy:
-        return True
-    import scipy.io
-
-    with InTemporaryDirectory():
-        with ImageOpener('test.mat.bz2', 'wb') as fobj:
-            try:
-                scipy.io.savemat(fobj, {'a': 1}, format='4')
-            except ValueError:
-                return True
-            else:
-                return False
-
-
 def assert_data_similar(arr, params):
     """ Check data is the same if recorded, otherwise check summaries
 

nibabel/tests/test_spm99analyze.py

@@ -31,7 +31,7 @@
 from ..testing import assert_allclose_safely, suppress_warnings
 
 from . import test_analyze
-from .test_helpers import (bytesio_round_trip, bytesio_filemap, bz2_mio_error)
+from .test_helpers import bytesio_round_trip, bytesio_filemap
 
 FLOAT_TYPES = np.sctypes['float']
 COMPLEX_TYPES = np.sctypes['complex']
@@ -404,8 +404,6 @@ def test_nan2zero_range_ok(self):
 class TestSpm99AnalyzeImage(test_analyze.TestAnalyzeImage, ImageScalingMixin):
     # class for testing images
     image_class = Spm99AnalyzeImage
-    # Flag to skip bz2 save tests if they are going to break
-    bad_bz2 = bz2_mio_error()
 
     # Decorating the old way, before the team invented @
     test_data_hdr_cache = (scipy_skip(