TEST: Drop unittest.TestCase base class; pytest does not need it

Author: effigies

nibabel/testing/__init__.py

@@ -210,19 +210,6 @@ def assert_arr_dict_equal(dict1, dict2):
         assert_array_equal(value1, value2)
 
 
-class BaseTestCase(unittest.TestCase):
-    """TestCase that does not attempt to run if prefixed with a ``_``
-
-    This restores the nose-like behavior of skipping so-named test cases
-    in test runners like pytest.
-    """
-
-    def setUp(self):
-        if self.__class__.__name__.startswith('_'):
-            raise unittest.SkipTest('Base test case - subclass to run')
-        super().setUp()
-
-
 def expires(version):
     """Decorator to mark a test as xfail with ExpiredDeprecationError after version"""
     from packaging.version import Version

nibabel/tests/test_spatialimages.py

@@ -11,7 +11,6 @@
 
 import warnings
 from io import BytesIO
-from unittest import TestCase
 
 import numpy as np
 import pytest
@@ -205,7 +204,7 @@ def __array__(self, dtype='int16'):
         return np.arange(3, dtype=dtype)
 
 
-class TestSpatialImage(TestCase):
+class TestSpatialImage:
     # class for testing images
     image_class = SpatialImage
     can_save = False

nibabel/tests/test_wrapstruct.py

@@ -33,7 +33,6 @@
 from .. import imageglobals
 from ..batteryrunners import Report
 from ..spatialimages import HeaderDataError
-from ..testing import BaseTestCase
 from ..volumeutils import Recoder, native_code, swapped_code
 from ..wrapstruct import LabeledWrapStruct, WrapStruct, WrapStructError
 
@@ -101,7 +100,7 @@ def log_chk(hdr, level):
     return hdrc, message, raiser
 
 
-class _TestWrapStructBase(BaseTestCase):
+class _TestWrapStructBase:
     """Class implements base tests for binary headers
 
     It serves as a base class for other binary header tests