MNT: Drop DataobjImage.get_shape, deprecated in 1.2, expired in 3.0

Author: effigies

nibabel/dataobj_images.py

@@ -404,15 +404,6 @@ def shape(self):
     def ndim(self):
         return self._dataobj.ndim
 
-    @deprecate_with_version('get_shape method is deprecated.\n'
-                            'Please use the ``img.shape`` property '
-                            'instead.',
-                            '1.2', '3.0')
-    def get_shape(self):
-        """ Return shape for image
-        """
-        return self.shape
-
     @classmethod
     def from_file_map(klass, file_map, *, mmap=True, keep_file_open=None):
         """ Class method to create image from mapping in ``file_map``

nibabel/spatialimages.py

@@ -28,7 +28,6 @@
      ``fname``, where the derivation may differ between formats.
    * to_file_map() - save image to files with which the image is already
      associated.
-   * .get_shape() (deprecated)
 
 properties:
 

nibabel/tests/test_image_api.py

@@ -48,7 +48,6 @@
 from nibabel.testing import (bytesio_round_trip, bytesio_filemap, assert_data_similar,
                              clear_and_catch_warnings, nullcontext)
 from ..tmpdirs import InTemporaryDirectory
-from ..deprecator import ExpiredDeprecationError
 
 from .test_api_validators import ValidateAPI
 from .test_minc1 import EXAMPLE_IMAGES as MINC1_EXAMPLE_IMAGES
@@ -450,12 +449,6 @@ def validate_ndim(self, imaker, params):
         with pytest.raises(AttributeError):
             img.ndim = 5
 
-    def validate_shape_deprecated(self, imaker, params):
-        # Check deprecated get_shape API
-        img = imaker()
-        with pytest.raises(ExpiredDeprecationError):
-            img.get_shape()
-
     def validate_mmap_parameter(self, imaker, params):
         img = imaker()
         fname = img.get_filename()

nibabel/tests/test_removalschedule.py

@@ -21,6 +21,7 @@
 
 ATTRIBUTE_SCHEDULE = [
     ("5.0.0", [("nibabel.dataobj_images", "DataobjImage", "get_data")]),
+    ("4.0.0", [("nibabel.dataobj_images", "DataobjImage", "get_shape")]),
     # Verify that the test will be quiet if the schedule outlives the modules
     ("1.0.0", [("nibabel.nosuchmod", "anyobj", "anyattr"),
                ("nibabel.nifti1", "nosuchobj", "anyattr"),

nibabel/tests/test_spatialimages.py

@@ -301,15 +301,6 @@ def test_str(self):
         img = img_klass(np.zeros((2, 3, 4), dtype=np.int16), np.eye(4))
         assert len(str(img)) > 0
 
-    def test_get_shape(self):
-        # Check that get_shape raises an ExpiredDeprecationError
-        img_klass = self.image_class
-        # Assumes all possible images support int16
-        # See https://github.com/nipy/nibabel/issues/58
-        img = img_klass(np.arange(1, dtype=np.int16), np.eye(4))
-        with pytest.raises(ExpiredDeprecationError):
-            img.get_shape()
-
     def test_get_fdata(self):
         # Test array image and proxy image interface for floating point data
         img_klass = self.image_class