MNT: Remove ArrayProxy.header reference, deprecated in 2.2, expired in 3.0

Author: effigies

nibabel/arrayproxy.py

@@ -30,7 +30,6 @@
 
 import numpy as np
 
-from .deprecated import deprecate_with_version
 from .volumeutils import array_from_file, apply_read_scaling
 from .fileslice import fileslice, canonical_slicers
 from . import openers
@@ -90,7 +89,6 @@ class ArrayProxy(object):
     """
     # Assume Fortran array memory layout
     order = 'F'
-    _header = None
 
     def __init__(self, file_like, spec, *, mmap=True, keep_file_open=None):
         """Initialize array proxy instance
@@ -146,8 +144,6 @@ def __init__(self, file_like, spec, *, mmap=True, keep_file_open=None):
                    spec.get_data_offset(),
                    1. if slope is None else slope,
                    0. if inter is None else inter)
-            # Reference to original header; we will remove this soon
-            self._header = spec.copy()
         elif 2 <= len(spec) <= 5:
             optional = (0, 1., 0.)
             par = spec + optional[len(spec) - 2:]
@@ -269,11 +265,6 @@ def _should_keep_file_open(self, file_like, keep_file_open):
         persist_opener = keep_file_open or have_igzip
         return keep_file_open, persist_opener
 
-    @property
-    @deprecate_with_version('ArrayProxy.header deprecated', '2.2', '3.0')
-    def header(self):
-        return self._header
-
     @property
     def shape(self):
         return self._shape

nibabel/tests/test_proxy_api.py

@@ -323,11 +323,6 @@ def validate_slope_inter_offset(self, pmaker, params):
             with pytest.raises(AttributeError):
                 setattr(prox, attr_name, expected)
 
-    def validate_deprecated_header(self, pmaker, params):
-        prox, fio, hdr = pmaker()
-        with pytest.raises(ExpiredDeprecationError):
-            prox.header
-
 
 class TestSpm99AnalyzeProxyAPI(TestAnalyzeProxyAPI):
     # SPM-type analyze has slope scaling but not intercept

nibabel/tests/test_removalschedule.py

@@ -27,7 +27,8 @@
                ("nibabel.filebasedimages", "FileBasedImage", "filespec_to_files"),
                ("nibabel.filebasedimages", "FileBasedImage", "to_filespec"),
                ("nibabel.filebasedimages", "FileBasedImage", "to_files"),
-               ("nibabel.filebasedimages", "FileBasedImage", "from_files")]),
+               ("nibabel.filebasedimages", "FileBasedImage", "from_files"),
+               ("nibabel.arrayproxy", "ArrayProxy", "header")]),
     # Verify that the test will be quiet if the schedule outlives the modules
     ("1.0.0", [("nibabel.nosuchmod", "anyobj", "anyattr"),
                ("nibabel.nifti1", "nosuchobj", "anyattr"),