TEST: Remove last imports of nose

Author: effigies

nibabel/nicom/tests/test_dwiparams.py

@@ -6,10 +6,9 @@
 
 from ..dwiparams import B2q, q2bg
 
-from nose.tools import (assert_true, assert_false, assert_equal, assert_raises)
+import pytest
 
-from numpy.testing import (assert_array_equal, assert_array_almost_equal,
-                           assert_equal as np_assert_equal)
+from numpy.testing import (assert_array_almost_equal, assert_equal as np_assert_equal)
 
 
 def test_b2q():
@@ -27,17 +26,20 @@ def test_b2q():
     assert_array_almost_equal(-q * s, B2q(B))
     # Massive negative eigs
     B = np.eye(3) * -1
-    assert_raises(ValueError, B2q, B)
+    with pytest.raises(ValueError):
+        B2q(B)
     # no error if we up the tolerance
     q = B2q(B, tol=1)
     # Less massive negativity, dropping tol
     B = np.diag([-1e-14, 10., 1])
-    assert_raises(ValueError, B2q, B)
+    with pytest.raises(ValueError):
+        B2q(B)
     assert_array_almost_equal(B2q(B, tol=5e-13), [0, 10, 0])
     # Confirm that we assume symmetric
     B = np.eye(3)
     B[0, 1] = 1e-5
-    assert_raises(ValueError, B2q, B)
+    with pytest.raises(ValueError):
+        B2q(B)
 
 
 def test_q2bg():

nibabel/streamlines/tests/test_streamlines.py

@@ -10,9 +10,7 @@
 from nibabel.tmpdirs import InTemporaryDirectory
 from numpy.compat.py3k import asbytes
 
-from nibabel.testing import data_path
-from nibabel.testing import clear_and_catch_warnings
-from nose.tools import assert_equal, assert_raises, assert_true, assert_false
+from nibabel.testing import data_path, clear_and_catch_warnings
 
 from .test_tractogram import assert_tractogram_equal
 from ..tractogram import Tractogram, LazyTractogram
@@ -82,50 +80,50 @@ def test_is_supported_detect_format():
     # Test is_supported and detect_format functions
     # Empty file/string
     f = BytesIO()
-    assert_false(nib.streamlines.is_supported(f))
-    assert_false(nib.streamlines.is_supported(""))
-    assert_true(nib.streamlines.detect_format(f) is None)
-    assert_true(nib.streamlines.detect_format("") is None)
+    assert not nib.streamlines.is_supported(f)
+    assert not nib.streamlines.is_supported("")
+    assert nib.streamlines.detect_format(f) is None
+    assert nib.streamlines.detect_format("") is None
 
     # Valid file without extension
     for tfile_cls in FORMATS.values():
         f = BytesIO()
         f.write(asbytes(tfile_cls.MAGIC_NUMBER))
         f.seek(0, os.SEEK_SET)
-        assert_true(nib.streamlines.is_supported(f))
-        assert_true(nib.streamlines.detect_format(f) is tfile_cls)
+        assert nib.streamlines.is_supported(f)
+        assert nib.streamlines.detect_format(f) is tfile_cls
 
     # Wrong extension but right magic number
     for tfile_cls in FORMATS.values():
         with tempfile.TemporaryFile(mode="w+b", suffix=".txt") as f:
             f.write(asbytes(tfile_cls.MAGIC_NUMBER))
             f.seek(0, os.SEEK_SET)
-            assert_true(nib.streamlines.is_supported(f))
-            assert_true(nib.streamlines.detect_format(f) is tfile_cls)
+            assert nib.streamlines.is_supported(f)
+            assert nib.streamlines.detect_format(f) is tfile_cls
 
     # Good extension but wrong magic number
     for ext, tfile_cls in FORMATS.items():
         with tempfile.TemporaryFile(mode="w+b", suffix=ext) as f:
             f.write(b"pass")
             f.seek(0, os.SEEK_SET)
-            assert_false(nib.streamlines.is_supported(f))
-            assert_true(nib.streamlines.detect_format(f) is None)
+            assert not nib.streamlines.is_supported(f)
+            assert nib.streamlines.detect_format(f) is None
 
     # Wrong extension, string only
     f = "my_tractogram.asd"
-    assert_false(nib.streamlines.is_supported(f))
-    assert_true(nib.streamlines.detect_format(f) is None)
+    assert not nib.streamlines.is_supported(f)
+    assert nib.streamlines.detect_format(f) is None
 
     # Good extension, string only
     for ext, tfile_cls in FORMATS.items():
         f = "my_tractogram" + ext
-        assert_true(nib.streamlines.is_supported(f))
-        assert_equal(nib.streamlines.detect_format(f), tfile_cls)
+        assert nib.streamlines.is_supported(f)
+        assert nib.streamlines.detect_format(f) == tfile_cls
 
     # Extension should not be case-sensitive.
     for ext, tfile_cls in FORMATS.items():
         f = "my_tractogram" + ext.upper()
-        assert_true(nib.streamlines.detect_format(f) is tfile_cls)
+        assert nib.streamlines.detect_format(f) is tfile_cls
 
 
 class TestLoadSave(unittest.TestCase):
@@ -135,12 +133,12 @@ def test_load_empty_file(self):
             for empty_filename in DATA['empty_filenames']:
                 tfile = nib.streamlines.load(empty_filename,
                                              lazy_load=lazy_load)
-                assert_true(isinstance(tfile, TractogramFile))
+                assert isinstance(tfile, TractogramFile)
 
                 if lazy_load:
-                    assert_true(type(tfile.tractogram), Tractogram)
+                    assert type(tfile.tractogram), Tractogram
                 else:
-                    assert_true(type(tfile.tractogram), LazyTractogram)
+                    assert type(tfile.tractogram), LazyTractogram
 
                 assert_tractogram_equal(tfile.tractogram,
                                         DATA['empty_tractogram'])
@@ -150,12 +148,12 @@ def test_load_simple_file(self):
             for simple_filename in DATA['simple_filenames']:
                 tfile = nib.streamlines.load(simple_filename,
                                              lazy_load=lazy_load)
-                assert_true(isinstance(tfile, TractogramFile))
+                assert isinstance(tfile, TractogramFile)
 
                 if lazy_load:
-                    assert_true(type(tfile.tractogram), Tractogram)
+                    assert type(tfile.tractogram), Tractogram
                 else:
-                    assert_true(type(tfile.tractogram), LazyTractogram)
+                    assert type(tfile.tractogram), LazyTractogram
 
                 assert_tractogram_equal(tfile.tractogram,
                                         DATA['simple_tractogram'])
@@ -165,12 +163,12 @@ def test_load_complex_file(self):
             for complex_filename in DATA['complex_filenames']:
                 tfile = nib.streamlines.load(complex_filename,
                                              lazy_load=lazy_load)
-                assert_true(isinstance(tfile, TractogramFile))
+                assert isinstance(tfile, TractogramFile)
 
                 if lazy_load:
-                    assert_true(type(tfile.tractogram), Tractogram)
+                    assert type(tfile.tractogram), Tractogram
                 else:
-                    assert_true(type(tfile.tractogram), LazyTractogram)
+                    assert type(tfile.tractogram), LazyTractogram
 
                 tractogram = Tractogram(DATA['streamlines'],
                                         affine_to_rasmm=np.eye(4))
@@ -191,19 +189,19 @@ def test_save_tractogram_file(self):
         trk_file = trk.TrkFile(tractogram)
 
         # No need for keyword arguments.
-        assert_raises(ValueError, nib.streamlines.save,
-                      trk_file, "dummy.trk", header={})
+        with self.assertRaises(ValueError):
+            nib.streamlines.save(trk_file, "dummy.trk", header={})
 
         # Wrong extension.
         with clear_and_catch_warnings(record=True,
                                       modules=[nib.streamlines]) as w:
             trk_file = trk.TrkFile(tractogram)
-            assert_raises(ValueError, nib.streamlines.save,
-                          trk_file, "dummy.tck", header={})
+            with self.assertRaises(ValueError):
+                nib.streamlines.save(trk_file, "dummy.tck", header={})
 
-            assert_equal(len(w), 1)
-            assert_true(issubclass(w[0].category, ExtensionWarning))
-            assert_true("extension" in str(w[0].message))
+            assert len(w) == 1
+            assert issubclass(w[0].category, ExtensionWarning)
+            assert "extension" in str(w[0].message)
 
         with InTemporaryDirectory():
             nib.streamlines.save(trk_file, "dummy.trk")
@@ -250,9 +248,9 @@ def test_save_complex_file(self):
                         ((not cls.SUPPORTS_DATA_PER_POINT) +
                          (not cls.SUPPORTS_DATA_PER_STREAMLINE))
 
-                    assert_equal(len(w), nb_expected_warnings)
+                    assert len(w) == nb_expected_warnings
                     for i in range(nb_expected_warnings):
-                        assert_true(issubclass(w[i].category, Warning))
+                        assert issubclass(w[i].category, Warning)
 
                     tractogram = Tractogram(DATA['streamlines'],
                                             affine_to_rasmm=np.eye(4))
@@ -281,10 +279,12 @@ def test_save_sliced_tractogram(self):
                 assert_tractogram_equal(tractogram, original_tractogram)
 
     def test_load_unknown_format(self):
-        assert_raises(ValueError, nib.streamlines.load, "")
+        with self.assertRaises(ValueError):
+            nib.streamlines.load("")
 
     def test_save_unknown_format(self):
-        assert_raises(ValueError, nib.streamlines.save, Tractogram(), "")
+        with self.assertRaises(ValueError):
+            nib.streamlines.save(Tractogram(), "")
 
     def test_save_from_generator(self):
         tractogram = Tractogram(DATA['streamlines'],

nibabel/streamlines/tests/test_tractogram_file.py

@@ -4,7 +4,7 @@
 from ..tractogram import Tractogram
 from ..tractogram_file import TractogramFile
 
-from nose.tools import assert_raises, assert_equal
+import pytest
 
 
 def test_subclassing_tractogram_file():
@@ -23,7 +23,8 @@ def load(cls, fileobj, lazy_load=True):
         def create_empty_header(cls):
             return None
 
-    assert_raises(TypeError, DummyTractogramFile, Tractogram())
+    with pytest.raises(TypeError):
+        DummyTractogramFile(Tractogram())
 
     # Missing 'load' method
     class DummyTractogramFile(TractogramFile):
@@ -38,7 +39,8 @@ def save(self, fileobj):
         def create_empty_header(cls):
             return None
 
-    assert_raises(TypeError, DummyTractogramFile, Tractogram())
+    with pytest.raises(TypeError):
+        DummyTractogramFile(Tractogram())
 
     # Now we have everything required.
     class DummyTractogramFile(TractogramFile):
@@ -57,12 +59,14 @@ def save(self, fileobj):
     dtf = DummyTractogramFile(Tractogram())
 
     # Default create_empty_header is empty dict
-    assert_equal(dtf.header, {})
+    assert dtf.header == {}
 
 
 def test_tractogram_file():
-    assert_raises(NotImplementedError, TractogramFile.is_correct_format, "")
-    assert_raises(NotImplementedError, TractogramFile.load, "")
+    with pytest.raises(NotImplementedError):
+        TractogramFile.is_correct_format("")
+    with pytest.raises(NotImplementedError):
+        TractogramFile.load("")
 
     # Testing calling the 'save' method of `TractogramFile` object.
     class DummyTractogramFile(TractogramFile):
@@ -78,6 +82,5 @@ def load(cls, fileobj, lazy_load=True):
         def save(self, fileobj):
             pass
 
-    assert_raises(NotImplementedError,
-                  super(DummyTractogramFile,
-                        DummyTractogramFile(Tractogram)).save, "")
+    with pytest.raises(NotImplementedError):
+        super(DummyTractogramFile, DummyTractogramFile(Tractogram)).save("")

nibabel/streamlines/tests/test_utils.py

@@ -4,7 +4,8 @@
 
 from nibabel.testing import data_path
 from numpy.testing import assert_array_equal
-from nose.tools import assert_raises
+
+import pytest
 
 from ..utils import get_affine_from_reference
 
@@ -17,7 +18,8 @@ def test_get_affine_from_reference():
     # Get affine from an numpy array.
     assert_array_equal(get_affine_from_reference(affine), affine)
     wrong_ref = np.array([[1, 2, 3], [4, 5, 6]])
-    assert_raises(ValueError, get_affine_from_reference, wrong_ref)
+    with pytest.raises(ValueError):
+        get_affine_from_reference(wrong_ref)
 
     # Get affine from a `SpatialImage`.
     assert_array_equal(get_affine_from_reference(img), affine)