Skip to content

Conversation

@aidandj
Copy link
Collaborator

@aidandj aidandj commented Nov 24, 2025

Closes #652

@aidandj aidandj requested a review from nipunn1313 November 24, 2025 19:49
@aidandj aidandj mentioned this pull request Nov 24, 2025
Signed-off-by: Aidan Jensen <aidandj.github@gmail.com>
@aidandj aidandj force-pushed the aidan/dedot-imports branch from f1e563a to 945fcc4 Compare November 24, 2025 21:19
Copy link
Owner

@nipunn1313 nipunn1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure!

One high level thought - if we proliferate the number of boolean args / options, it will be hard to maintain the full intersection of optionality (number of configurations grows exponentially with number of bool args).

What's the goal here from dedotting? If there's some way to achieve the goal with defaults, it's worth considering. If it's a true option - then maybe we can just add the option.

@aidandj
Copy link
Collaborator Author

aidandj commented Nov 25, 2025

sure!

One high level thought - if we proliferate the number of boolean args / options, it will be hard to maintain the full intersection of optionality (number of configurations grows exponentially with number of bool args).

What's the goal here from dedotting? If there's some way to achieve the goal with defaults, it's worth considering. If it's a true option - then maybe we can just add the option.

This is sort of an experiment to see if it solves the request in the linked issue. I consider it a breaking change because I know for a fact people are manipulating import statements (I do it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Name the imports

2 participants