windows: fix(workaround) illegal instruction in release build

nillerusr · nillerusr · commit ff2211f0ad24 · 2022-12-17T10:14:49.000+03:00
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -46,7 +46,7 @@ jobs:
 
     steps:
     - uses: actions/checkout@v2
-    - name: Build windows-i386
+    - name: Build windows-amd64
       run: |
         git submodule init && git submodule update
         ./waf.bat configure -T debug -8
diff --git a/engine/tmessage.cpp b/engine/tmessage.cpp
@@ -322,10 +322,17 @@ int ParseDirective( const char *pText )
 		{
 			if ( ParseFloats( pText, tempFloat, 4 ) )
 			{
-				for ( int i = 0; i < 4; ++i )
+				// that's original code, msvc2015 generates illegal instruction on amd64 architecture
+				/*for ( int i = 0; i < 4; ++i )
 				{
 					gMessageParms.boxcolor[ i ] = (byte)(int)tempFloat[ i ];
-				}
+				}*/
+
+				// workaround
+				gMessageParms.boxcolor[0] = (int)tempFloat[0];
+				gMessageParms.boxcolor[1] = (int)tempFloat[1];
+				gMessageParms.boxcolor[2] = (int)tempFloat[2];
+				gMessageParms.boxcolor[3] = (int)tempFloat[3];
 			}
 		}
 		else if ( IsToken( pText, "clearmessage" ) )

Original file line number	Diff line number	Diff line change
`@@ -322,10 +322,17 @@ int ParseDirective( const char *pText )`
`322`	`322`	`{`
`323`	`323`	`if ( ParseFloats( pText, tempFloat, 4 ) )`
`324`	`324`	`{`
`325`		`- for ( int i = 0; i < 4; ++i )`
	`325`	`+ // that's original code, msvc2015 generates illegal instruction on amd64 architecture`
	`326`	`+ /*for ( int i = 0; i < 4; ++i )`
`326`	`327`	`{`
`327`	`328`	`gMessageParms.boxcolor[ i ] = (byte)(int)tempFloat[ i ];`
`328`		`- }`
	`329`	`+ }*/`
	`330`	`+`
	`331`	`+ // workaround`
	`332`	`+ gMessageParms.boxcolor[0] = (int)tempFloat[0];`
	`333`	`+ gMessageParms.boxcolor[1] = (int)tempFloat[1];`
	`334`	`+ gMessageParms.boxcolor[2] = (int)tempFloat[2];`
	`335`	`+ gMessageParms.boxcolor[3] = (int)tempFloat[3];`
`329`	`336`	`}`
`330`	`337`	`}`
`331`	`338`	`else if ( IsToken( pText, "clearmessage" ) )`