Commit b8a2e5d
committed
minor symfony#7099 Clarify Process::wait() callback behaviour (Lilchef)
This PR was submitted for the 3.1 branch but it was merged into the 2.7 branch instead (closes symfony#7099).
Discussion
----------
Clarify Process::wait() callback behaviour
There was no clear description of when the Process::wait() callback was triggered and it seemed like it would be called once the process was complete which is incorrect.
I lost several hours after misunderstanding how this works and then trying to figure out why my 'after process' code was being triggered before the process had finished. Hopefully this change makes it clearer.
Commits
-------
d696a15 Clarify Process::wait() callback behaviour1 file changed
+17
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
116 | 120 | | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
117 | 134 | | |
118 | 135 | | |
119 | 136 | | |
| |||
122 | 139 | | |
123 | 140 | | |
124 | 141 | | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | 142 | | |
132 | 143 | | |
133 | 144 | | |
| |||
0 commit comments