minor symfony#28513 [Validator] add exception when intl component not found (ronfroy)

This PR was squashed before being merged into the 4.2-dev branch (closes symfony#28513).

Discussion
----------

[Validator] add exception when intl component not found

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

<!--
Add some exception when the Intl component is not found but required on some constraints
-->

Commits
-------

b6f29f4 [Validator] add exception when intl component not found

Author: nicolas-grekas

src/Symfony/Component/Validator/Constraints/BicValidator.php

@@ -14,6 +14,7 @@
 use Symfony\Component\Intl\Intl;
 use Symfony\Component\Validator\Constraint;
 use Symfony\Component\Validator\ConstraintValidator;
+use Symfony\Component\Validator\Exception\LogicException;
 use Symfony\Component\Validator\Exception\UnexpectedTypeException;
 
 /**
@@ -68,10 +69,11 @@ public function validate($value, Constraint $constraint)
             return;
         }
 
-        // next 2 letters must be alphabetic (country code)
         if (!class_exists(Intl::class)) {
-            throw new \LogicException('The "symfony/intl" component is required to use the Bic constraint.');
+            throw new LogicException('The "symfony/intl" component is required to use the Bic constraint.');
         }
+
+        // next 2 letters must be alphabetic (country code)
         $countries = Intl::getRegionBundle()->getCountryNames();
         if (!isset($countries[substr($canonicalize, 4, 2)])) {
             $this->context->buildViolation($constraint->message)

src/Symfony/Component/Validator/Constraints/CountryValidator.php

@@ -14,6 +14,7 @@
 use Symfony\Component\Intl\Intl;
 use Symfony\Component\Validator\Constraint;
 use Symfony\Component\Validator\ConstraintValidator;
+use Symfony\Component\Validator\Exception\LogicException;
 use Symfony\Component\Validator\Exception\UnexpectedTypeException;
 
 /**
@@ -40,6 +41,10 @@ public function validate($value, Constraint $constraint)
             throw new UnexpectedTypeException($value, 'string');
         }
 
+        if (!class_exists(Intl::class)) {
+            throw new LogicException('The "symfony/intl" component is required to use the Country constraint.');
+        }
+
         $value = (string) $value;
         $countries = Intl::getRegionBundle()->getCountryNames();
 

src/Symfony/Component/Validator/Constraints/CurrencyValidator.php

@@ -14,6 +14,7 @@
 use Symfony\Component\Intl\Intl;
 use Symfony\Component\Validator\Constraint;
 use Symfony\Component\Validator\ConstraintValidator;
+use Symfony\Component\Validator\Exception\LogicException;
 use Symfony\Component\Validator\Exception\UnexpectedTypeException;
 
 /**
@@ -41,6 +42,10 @@ public function validate($value, Constraint $constraint)
             throw new UnexpectedTypeException($value, 'string');
         }
 
+        if (!class_exists(Intl::class)) {
+            throw new LogicException('The "symfony/intl" component is required to use the Currency constraint.');
+        }
+
         $value = (string) $value;
         $currencies = Intl::getCurrencyBundle()->getCurrencyNames();
 

src/Symfony/Component/Validator/Constraints/LanguageValidator.php

@@ -14,6 +14,7 @@
 use Symfony\Component\Intl\Intl;
 use Symfony\Component\Validator\Constraint;
 use Symfony\Component\Validator\ConstraintValidator;
+use Symfony\Component\Validator\Exception\LogicException;
 use Symfony\Component\Validator\Exception\UnexpectedTypeException;
 
 /**
@@ -40,6 +41,10 @@ public function validate($value, Constraint $constraint)
             throw new UnexpectedTypeException($value, 'string');
         }
 
+        if (!class_exists(Intl::class)) {
+            throw new LogicException('The "symfony/intl" component is required to use the Language constraint.');
+        }
+
         $value = (string) $value;
         $languages = Intl::getLanguageBundle()->getLanguageNames();
 

src/Symfony/Component/Validator/Exception/LogicException.php

@@ -0,0 +1,16 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Validator\Exception;
+
+class LogicException extends \LogicException implements ExceptionInterface
+{
+}

src/Symfony/Component/Validator/Mapping/Factory/BlackHoleMetadataFactory.php

@@ -11,6 +11,8 @@
 
 namespace Symfony\Component\Validator\Mapping\Factory;
 
+use Symfony\Component\Validator\Exception\LogicException;
+
 /**
  * Metadata factory that does not store metadata.
  *
@@ -27,7 +29,7 @@ class BlackHoleMetadataFactory implements MetadataFactoryInterface
      */
     public function getMetadataFor($value)
     {
-        throw new \LogicException('This class does not support metadata.');
+        throw new LogicException('This class does not support metadata.');
     }
 
     /**

src/Symfony/Component/Validator/Tests/Mapping/Factory/BlackHoleMetadataFactoryTest.php

@@ -17,7 +17,7 @@
 class BlackHoleMetadataFactoryTest extends TestCase
 {
     /**
-     * @expectedException \LogicException
+     * @expectedException \Symfony\Component\Validator\Exception\LogicException
      */
     public function testGetMetadataForThrowsALogicException()
     {

src/Symfony/Component/Validator/ValidatorBuilder.php

@@ -17,6 +17,7 @@
 use Doctrine\Common\Cache\ArrayCache;
 use Symfony\Component\Translation\TranslatorInterface as LegacyTranslatorInterface;
 use Symfony\Component\Validator\Context\ExecutionContextFactory;
+use Symfony\Component\Validator\Exception\LogicException;
 use Symfony\Component\Validator\Exception\ValidatorException;
 use Symfony\Component\Validator\Mapping\Cache\CacheInterface;
 use Symfony\Component\Validator\Mapping\Factory\LazyLoadingMetadataFactory;
@@ -191,8 +192,8 @@ public function enableAnnotationMapping(Reader $annotationReader = null)
         }
 
         if (null === $annotationReader) {
-            if (!class_exists('Doctrine\Common\Annotations\AnnotationReader') || !class_exists('Doctrine\Common\Cache\ArrayCache')) {
-                throw new \RuntimeException('Enabling annotation based constraint mapping requires the packages doctrine/annotations and doctrine/cache to be installed.');
+            if (!class_exists(AnnotationReader::class) || !class_exists(ArrayCache::class)) {
+                throw new LogicException('Enabling annotation based constraint mapping requires the packages doctrine/annotations and doctrine/cache to be installed.');
             }
 
             $annotationReader = new CachedReader(new AnnotationReader(), new ArrayCache());