Get rid of unused event classes.

Author: nickygerritsen

webapp/src/DataTransferObject/Shadowing/Account.php

@@ -30,15 +30,11 @@ public static function fromString(string $value): EventType
     }
 
     /**
-     * @return class-string<EventData>
+     * @return class-string<EventData>|null
      */
-    public function getEventClass(): string
+    public function getEventClass(): ?string
     {
         switch ($this) {
-            case self::ACCOUNTS:
-                return Account::class;
-            case self::AWARDS:
-                return Award::class;
             case self::CLARIFICATIONS:
                 return ClarificationEvent::class;
             case self::CONTESTS:
@@ -63,8 +59,7 @@ public function getEventClass(): string
                 return SubmissionEvent::class;
             case self::TEAMS:
                 return TeamEvent::class;
-            case self::TEAM_MEMBERS:
-                return TeamMember::class;
         }
+        return null;
     }
 }

webapp/src/DataTransferObject/Shadowing/Award.php

@@ -39,6 +39,9 @@ public function denormalize(
 
         $eventType = $context['event_type'];
         $eventClass = $eventType->getEventClass();
+        if ($eventClass === null) {
+            return null;
+        }
 
         // Unset the event type, so we are not calling ourselves recursively
         unset($context['event_type']);

webapp/src/DataTransferObject/Shadowing/EventType.php

@@ -62,17 +62,24 @@ public function denormalize(
             } else {
                 $id = null;
             }
+            if ($eventType->getEventClass() === null) {
+                $eventData = [];
+            } else {
+                $eventData = isset($data['data']) ? $this->serializer->denormalize($data['data'], EventData::class . '[]', $format, $context + ['event_type' => $eventType]) : [];
+            }
             return new Event(
                 $data['token'] ?? null,
                 $eventType,
                 $operation,
                 $id,
-                isset($data['data']) ? $this->serializer->denormalize($data['data'], EventData::class . '[]', $format, $context + ['event_type' => $eventType]) : [],
+                $eventData,
             );
         } else {
             $operation = Operation::from($data['op']);
             if ($operation === Operation::DELETE) {
                 $eventData = [];
+            } elseif ($eventType->getEventClass() === null) {
+                $eventData = [];
             } else {
                 $eventData = [$this->serializer->denormalize($data['data'], EventData::class, $format, $context + ['event_type' => $eventType])];
             }

webapp/src/DataTransferObject/Shadowing/TeamMember.php

@@ -24,7 +24,7 @@ public function testDenormalizeUseContext(
         Operation $expectedOperation,
         ?string $expectedObjectId,
         array $expectedData
-    ) {
+    ): void {
         $serializer = $this->getcontainer()->get(SerializerInterface::class);
         $event = $serializer->denormalize($data, Event::class, 'json', $context);
         self::assertEquals($expectedId, $event->id);
@@ -45,7 +45,7 @@ public function testDenormalizeDoNotUseContext(
         Operation $expectedOperation,
         ?string $expectedObjectId,
         array $expectedData
-    ) {
+    ): void {
         $serializer = $this->getcontainer()->get(SerializerInterface::class);
         $event = $serializer->denormalize($data, Event::class, 'json', ['api_version' => null]);
         self::assertEquals($expectedId, $event->id);
@@ -87,6 +87,21 @@ public function provideDenormalize(): Generator
                 ),
             ],
         ];
+        yield '2022-07 format, create/update unknown class' => [
+            [
+                'type' => 'team-members',
+                'token' => 'sometoken',
+                'data' => [
+                    ['id' => '123'],
+                ],
+            ],
+            ['api_version' => '2022-07'],
+            'sometoken',
+            EventType::TEAM_MEMBERS,
+            Operation::CREATE,
+            '123',
+            [],
+        ];
         yield '2022-07 format, create/update multiple' => [
             [
                 'type' => 'languages',