Make obsolete abstract virtual

Author: fredericDelaporte

src/NHibernate/Persister/Collection/AbstractCollectionPersister.cs

@@ -1649,15 +1649,24 @@ public object NotFoundObject
 		// 6.0 TODO: Remove (Replace with ISupportSelectModeJoinable.SelectFragment)
 		// Since v5.2
 		[Obsolete("Use overload taking includeLazyProperties parameter")]
-		public abstract string SelectFragment(IJoinable rhs, string rhsAlias, string lhsAlias, string currentEntitySuffix,
-											  string currentCollectionSuffix, bool includeCollectionColumns);
-		
+		public virtual string SelectFragment(
+			IJoinable rhs,
+			string rhsAlias,
+			string lhsAlias,
+			string currentEntitySuffix,
+			string currentCollectionSuffix,
+			bool includeCollectionColumns)
+		{
+			return SelectFragment(
+				rhs, rhsAlias, lhsAlias, currentEntitySuffix, currentCollectionSuffix, includeCollectionColumns, false);
+		}
+
 		// 6.0 TODO: Make abstract
 		public virtual string SelectFragment(
 			IJoinable rhs, string rhsAlias, string lhsAlias, string entitySuffix, string collectionSuffix,
 			bool includeCollectionColumns, bool includeLazyProperties)
 		{
-			throw new NotImplementedException("Fetching lazy properties is not implemented by " + GetType().FullName);
+			throw new NotImplementedException("SelectFragment with fetching lazy properties option is not implemented by " + GetType().FullName);
 		}
 
 		/// <summary>

src/NHibernate/Persister/Collection/BasicCollectionPersister.cs

@@ -263,14 +263,6 @@ public override string SelectFragment(IJoinable rhs, string rhsAlias, string lhs
 			return includeCollectionColumns ? SelectFragment(lhsAlias, collectionSuffix) : string.Empty;
 		}
 
-		// Since v5.2
-		[Obsolete("Use overload taking includeLazyProperties parameter")]
-		public override string SelectFragment(IJoinable rhs, string rhsAlias, string lhsAlias,
-			string entitySuffix, string collectionSuffix, bool includeCollectionColumns)
-		{
-			return SelectFragment(rhs, rhsAlias, lhsAlias, entitySuffix, collectionSuffix, includeCollectionColumns, false);
-		}
-
 		private string ManyToManySelectFragment(IJoinable rhs, string rhsAlias, string lhsAlias, string collectionSuffix)
 		{
 			SelectFragment frag = GenerateSelectFragment(lhsAlias, collectionSuffix);

src/NHibernate/Persister/Collection/OneToManyPersister.cs

@@ -303,13 +303,6 @@ protected override int DoUpdateRows(object id, IPersistentCollection collection,
 			}
 		}
 
-		// Since v5.2
-		[Obsolete("Use overload taking includeLazyProperties parameter")]
-		public override string SelectFragment(IJoinable rhs, string rhsAlias, string lhsAlias, string entitySuffix, string collectionSuffix, bool includeCollectionColumns)
-		{
-			return SelectFragment(rhs, rhsAlias, lhsAlias, entitySuffix, collectionSuffix, includeCollectionColumns, false);
-		}
-
 		public override string SelectFragment(IJoinable rhs, string rhsAlias, string lhsAlias, string entitySuffix, string collectionSuffix, bool includeCollectionColumns, bool fetchLazyProperties)
 		{
 			var buf = new StringBuilder();