Use pattern matching to check and perform type conversion (#572)

+semver:patch

Author: deepsource-autofix[bot]

src/FluentNHibernate/Automapping/AutoMapping.cs

@@ -39,9 +39,7 @@ IEnumerable<Member> IMappingProvider.GetIgnoredProperties()
         void IAutoClasslike.AlterModel(ClassMappingBase mapping)
         {
             mapping.MergeAttributes(attributes.Clone());
-
-            var classMapping = mapping as ClassMapping;
-            if (classMapping != null)
+            if (mapping is ClassMapping classMapping)
             {
                 if (providers.Id != null)
                     classMapping.Set(x => x.Id, Layer.Defaults, providers.Id.GetIdentityMapping());

src/FluentNHibernate/MappingModel/TypeReference.cs

@@ -148,7 +148,7 @@ public override bool Equals(object obj)
                 return Equals((TypeReference)obj);
             if (obj is Type)
                 return Equals((Type)obj);
-            if (obj.GetType() == typeof(string))
+            if (obj is string)
                 return Equals((string)obj);
 
             return false;
@@ -202,4 +202,4 @@ public Type GetUnderlyingSystemType()
             return !(original == other);
         }
     }
-}
+}

src/FluentNHibernate/Utils/ExpressionToSql.cs

@@ -32,11 +32,9 @@ public static string Convert<T>(Expression<Func<T, bool>> expression)
         {
             if (expression.Body is BinaryExpression)
                 return Convert<T>((BinaryExpression)expression.Body);
-            var memberExpression = expression.Body as MemberExpression;
-            if (memberExpression != null && memberExpression.Type == typeof(bool))
+            if (expression.Body is MemberExpression memberExpression && memberExpression.Type == typeof(bool))
                     return Convert(CreateExpression<T>(memberExpression)) + " = " + Convert(true);
-            var unaryExpression = expression.Body as UnaryExpression;
-            if (unaryExpression != null && unaryExpression.Type == typeof(bool) && unaryExpression.NodeType == ExpressionType.Not)
+            if (expression.Body is UnaryExpression unaryExpression && unaryExpression.Type == typeof(bool) && unaryExpression.NodeType == ExpressionType.Not)
                     return Convert(CreateExpression<T>(unaryExpression.Operand)) + " = " + Convert(false);
 
             throw new InvalidOperationException("Unable to convert expression to SQL");
@@ -68,19 +66,14 @@ private static string Convert(MethodCallExpression body)
 
         private static string Convert<T>(Expression<Func<T, object>> expression, UnaryExpression body)
         {
-            var constant = body.Operand as ConstantExpression;
 
-            if (constant != null)
+            if (body.Operand is ConstantExpression constant)
                 return Convert(constant);
 
-            var member = body.Operand as MemberExpression;
-
-            if (member != null)
+            if (body.Operand is MemberExpression member)
                 return Convert(expression, member);
 
-            var unaryExpression = body.Operand as UnaryExpression;
-
-            if (unaryExpression != null && unaryExpression.NodeType == ExpressionType.Convert)
+            if (body.Operand is UnaryExpression unaryExpression && unaryExpression.NodeType == ExpressionType.Convert)
                 return Convert(expression, unaryExpression);
 
             throw new InvalidOperationException("Unable to convert expression to SQL");