Make properties readonly where possible (#658)

+semver:patch

Author: hazzik

src/FluentNHibernate/Cfg/FluentConfigurationException.cs

@@ -20,7 +20,7 @@ protected FluentConfigurationException(SerializationInfo info, StreamingContext
         this.PotentialReasons = info.GetValue("PotentialReasons", typeof(List<string>)) as List<string>;            
     }
 
-    public IList<string> PotentialReasons { get; private set; }
+    public IList<string> PotentialReasons { get; }
 
     public override string Message
     {

src/FluentNHibernate/Cfg/MappingConfiguration.cs

@@ -37,17 +37,17 @@ public MappingConfiguration UsePersistenceModel(PersistenceModel persistenceMode
     /// <summary>
     /// Fluent mappings
     /// </summary>
-    public FluentMappingsContainer FluentMappings { get; private set; }
+    public FluentMappingsContainer FluentMappings { get; }
 
     /// <summary>
     /// Automatic mapping configurations
     /// </summary>
-    public AutoMappingsContainer AutoMappings { get; private set; }
+    public AutoMappingsContainer AutoMappings { get; }
 
     /// <summary>
     /// Hbm mappings
     /// </summary>
-    public HbmMappingsContainer HbmMappings { get; private set; }
+    public HbmMappingsContainer HbmMappings { get; }
 
     /// <summary>
     /// Get whether any mappings of any kind were added

src/FluentNHibernate/Conventions/ConventionsCollection.cs

@@ -55,8 +55,8 @@ public IEnumerable<object> this[Type type]
 
     private class AddedConvention
     {
-        public IList<object> Instances { get; private set; }
-        public Type Type { get; private set; }
+        public IList<object> Instances { get; }
+        public Type Type { get; }
 
         public AddedConvention(Type type)
         {

src/FluentNHibernate/Conventions/Inspections/ColumnInspector.cs

@@ -14,7 +14,7 @@ public ColumnInspector(Type containingEntityType, ColumnMapping mapping)
         this.mapping = mapping;
     }
 
-    public Type EntityType { get; private set; }
+    public Type EntityType { get; }
 
     public string Name => mapping.Name;
 

src/FluentNHibernate/Diagnostics/DiagnosticResults.cs

@@ -17,10 +17,10 @@ public DiagnosticResults(IEnumerable<ScannedSource> scannedSources, IEnumerable<
         AutomappedTypes = automappingTypes.ToArray();
     }
 
-    public IEnumerable<Type> FluentMappings { get; private set; }
-    public IEnumerable<ScannedSource> ScannedSources { get; private set; }
-    public IEnumerable<Type> Conventions { get; private set; }
-    public IEnumerable<SkippedAutomappingType> AutomappingSkippedTypes { get; private set; }
-    public IEnumerable<Type> AutomappingCandidateTypes { get; private set; }
-    public IEnumerable<AutomappingType> AutomappedTypes { get; private set; }
+    public IEnumerable<Type> FluentMappings { get; }
+    public IEnumerable<ScannedSource> ScannedSources { get; }
+    public IEnumerable<Type> Conventions { get; }
+    public IEnumerable<SkippedAutomappingType> AutomappingSkippedTypes { get; }
+    public IEnumerable<Type> AutomappingCandidateTypes { get; }
+    public IEnumerable<AutomappingType> AutomappedTypes { get; }
 }

src/FluentNHibernate/Mapping/ClassMap.cs

@@ -55,7 +55,7 @@ protected ClassMap(AttributeStore attributes, MappingProviderStore providers)
     /// <example>
     /// Cache.ReadWrite();
     /// </example>
-    public CachePart Cache { get; private set; }
+    public CachePart Cache { get; }
 
     /// <summary>
     /// Specify settings for the container/hibernate-mapping for this class.

src/FluentNHibernate/Mapping/IdentityGenerationStrategyBuilder.cs

@@ -441,7 +441,7 @@ public TParent Custom(string generator, Action<ParamBuilder> paramValues)
 
     /// <summary>
     /// Generator that uses the RDBMS native function to generate a GUID.
-    /// The behavior is similar to the “sequence” generator. When a new
+    /// The behavior is similar to the �sequence� generator. When a new
     /// object is saved NH run two queries: the first to retrieve the GUID
     /// value and the second to insert the entity using the Guid retrieved
     /// from the RDBMS. Your entity Id must be System.Guid and the SQLType
@@ -457,7 +457,7 @@ public TParent GuidNative()
 
     /// <summary>
     /// Generator that uses the RDBMS native function to generate a GUID.
-    /// The behavior is similar to the “sequence” generator. When a new
+    /// The behavior is similar to the �sequence� generator. When a new
     /// object is saved NH run two queries: the first to retrieve the GUID
     /// value and the second to insert the entity using the Guid retrieved
     /// from the RDBMS. Your entity Id must be System.Guid and the SQLType

src/FluentNHibernate/Mapping/IdentityPart.cs

@@ -60,7 +60,7 @@ void SetDefaultAccess()
     /// Id("PersonId")
     ///   .GeneratedBy.Assigned();
     /// </example>
-    public IdentityGenerationStrategyBuilder<IdentityPart> GeneratedBy { get; private set; }
+    public IdentityGenerationStrategyBuilder<IdentityPart> GeneratedBy { get; }
 
     /// <summary>
     /// Set the access and naming strategy for this identity.

src/FluentNHibernate/Mapping/KeyManyToOnePart.cs

@@ -39,9 +39,9 @@ public KeyManyToOnePart ForeignKey(string foreignKey)
     /// <summary>
     /// Defines how NHibernate will access the object for persisting/hydrating (Defaults to Property)
     /// </summary>
-    public AccessStrategyBuilder<KeyManyToOnePart> Access { get; private set; }
+    public AccessStrategyBuilder<KeyManyToOnePart> Access { get; }
 
-    public NotFoundExpression<KeyManyToOnePart> NotFound { get; private set; }
+    public NotFoundExpression<KeyManyToOnePart> NotFound { get; }
 
     public KeyManyToOnePart Lazy()
     {

src/FluentNHibernate/Mapping/KeyPropertyPart.cs

@@ -40,5 +40,5 @@ public KeyPropertyPart Length(int length)
         return this;
     }
 
-    public AccessStrategyBuilder<KeyPropertyPart> Access { get; private set; }
+    public AccessStrategyBuilder<KeyPropertyPart> Access { get; }
 }