Remove redundant private modifiers (#670)

+semver:patch

Author: hazzik

src/FluentNHibernate.Testing/Utils/ExtensionsTests.cs

@@ -13,12 +13,12 @@ public PublicConstructor() { }
 
     class PrivateConstructor
     {
-        private PrivateConstructor() { }
+        PrivateConstructor() { }
     }
 
     class ConstructorWithArguments
     {
-        private ConstructorWithArguments(int number) { }
+        ConstructorWithArguments(int number) { }
     }
 
     [Test]

src/FluentNHibernate/Cfg/Db/PersistenceConfiguration.cs

@@ -37,11 +37,11 @@ public abstract class PersistenceConfiguration<TThisConfiguration, TConnectionSt
     protected const string AdoNetBatchSizeKey = NHibEnvironment.BatchSize;
     protected const string CurrentSessionContextClassKey = "current_session_context_class";
 
-    private readonly Dictionary<string, string> values = new Dictionary<string, string>();
+    readonly Dictionary<string, string> values = new Dictionary<string, string>();
 
-    private bool nextBoolSettingValue = true;
-    private readonly TConnectionString connectionString;
-    private readonly CacheSettingsBuilder cache = new CacheSettingsBuilder();
+    bool nextBoolSettingValue = true;
+    readonly TConnectionString connectionString;
+    readonly CacheSettingsBuilder cache = new CacheSettingsBuilder();
 
     protected PersistenceConfiguration()
     {
@@ -71,7 +71,7 @@ static IEnumerable<string> OverridenDefaults(IDictionary<string,string> settings
             yield return ConnectionProviderKey;
     }
 
-    private static IEnumerable<string> KeysToPreserve(NHibConfiguration nhibernateConfig, IDictionary<string, string> settings)
+    static IEnumerable<string> KeysToPreserve(NHibConfiguration nhibernateConfig, IDictionary<string, string> settings)
     {
         var @default = new NHibConfiguration();
         return nhibernateConfig.Properties

src/FluentNHibernate/Mapping/AnyPart.cs

@@ -15,13 +15,13 @@ namespace FluentNHibernate.Mapping;
 /// </summary>
 public class AnyPart<T> : IAnyMappingProvider
 {
-    private readonly AttributeStore attributes = new AttributeStore();
-    private readonly Type entity;
-    private readonly Member member;
-    private readonly IList<string> typeColumns = new List<string>();
-    private readonly IList<string> identifierColumns = new List<string>();
-    private readonly IList<MetaValueMapping> metaValues = new List<MetaValueMapping>();
-    private bool nextBool = true;
+    readonly AttributeStore attributes = new AttributeStore();
+    readonly Type entity;
+    readonly Member member;
+    readonly IList<string> typeColumns = new List<string>();
+    readonly IList<string> identifierColumns = new List<string>();
+    readonly IList<MetaValueMapping> metaValues = new List<MetaValueMapping>();
+    bool nextBool = true;
     bool idTypeSet;
 
     public AnyPart(Type entity, Member member)

src/FluentNHibernate/Mapping/PropertyPart.cs

@@ -15,7 +15,7 @@ public class PropertyPart : IPropertyMappingProvider
     readonly AttributeStore attributes = new AttributeStore();
     readonly AttributeStore columnAttributes = new AttributeStore();
 
-    private bool nextBool = true;
+    bool nextBool = true;
 
     public PropertyPart(Member member, Type parentType)
     {
@@ -201,7 +201,7 @@ public PropertyPart CustomType(Func<Type, Type> typeFunc)
         return CustomType(TypeMapping.GetTypeString(type));
     }
 
-    private void AddColumnsFromCompositeUserType(Type compositeUserType)
+    void AddColumnsFromCompositeUserType(Type compositeUserType)
     {
         var inst = (ICompositeUserType)Activator.CreateInstance(compositeUserType);
 

src/FluentNHibernate/Mapping/ReferenceComponentPart.cs

@@ -12,7 +12,7 @@ namespace FluentNHibernate.Mapping;
 /// <typeparam name="T">Component type</typeparam>
 public class ReferenceComponentPart<T>(Member property, Type containingEntityType) : IReferenceComponentMappingProvider
 {
-    private string columnPrefix;
+    string columnPrefix;
 
     /// <summary>
     /// Sets the prefix for any columns defined within the component. To refer to the property

src/FluentNHibernate/Mapping/ToManyBase.cs

@@ -390,7 +390,7 @@ public T AsIndexedCollection<TIndex>(string indexColumn, Action<IndexPart> custo
         return (T)this;
     }
 
-    private void CreateIndexMapping(Action<IndexPart> customIndex)
+    void CreateIndexMapping(Action<IndexPart> customIndex)
     {
         var indexPart = new IndexPart(typeof(T));
 
@@ -401,7 +401,7 @@ private void CreateIndexMapping(Action<IndexPart> customIndex)
 #pragma warning restore 612,618
     }
 
-    private void CreateListIndexMapping(Action<ListIndexPart> customIndex)
+    void CreateListIndexMapping(Action<ListIndexPart> customIndex)
     {
         indexMapping = new IndexMapping();
         var builder = new ListIndexPart(indexMapping);
@@ -737,7 +737,7 @@ protected virtual CollectionMapping GetCollectionMapping()
         return mapping;
     }
 
-    private string GetDefaultName()
+    string GetDefaultName()
     {
         if (member.IsMethod)
         {

src/FluentNHibernate/PersistenceModel.cs

@@ -29,11 +29,12 @@ public class PersistenceModel
     {
         new ComponentMapComponentReferenceResolver()
     };
-    private readonly IList<IMappingModelVisitor> visitors = new List<IMappingModelVisitor>();
+
+    readonly IList<IMappingModelVisitor> visitors = new List<IMappingModelVisitor>();
     public IConventionFinder Conventions { get; }
     public bool MergeMappings { get; set; }
-    private IEnumerable<HibernateMapping> compiledMappings;
-    private ValidationVisitor validationVisitor;
+    IEnumerable<HibernateMapping> compiledMappings;
+    ValidationVisitor validationVisitor;
     public PairBiDirectionalManyToManySidesDelegate BiDirectionalManyToManyPairer { get; set; }
 
     IDiagnosticMessageDispatcher diagnosticDispatcher = new DefaultDiagnosticMessageDispatcher();
@@ -86,7 +87,7 @@ public void AddMappingsFromSource(ITypeSource source)
         log.LoadedFluentMappingsFromSource(source);
     }
 
-    private static Assembly FindTheCallingAssembly()
+    static Assembly FindTheCallingAssembly()
     {
         StackTrace trace = new StackTrace(false);
 
@@ -150,7 +151,7 @@ public void Add(Type type)
             throw new InvalidOperationException("Unsupported mapping type '" + type.FullName + "'");
     }
 
-    private bool IsMappingOf<T>(Type type)
+    bool IsMappingOf<T>(Type type)
     {
         return !type.IsGenericType && typeof(T).IsAssignableFrom(type);
     }
@@ -171,7 +172,7 @@ public virtual IEnumerable<HibernateMapping> BuildMappings()
         return hbms;
     }
 
-    private void BuildSeparateMappings(Action<HibernateMapping> add)
+    void BuildSeparateMappings(Action<HibernateMapping> add)
     {
         foreach (var classMap in classProviders)
         {
@@ -190,7 +191,7 @@ private void BuildSeparateMappings(Action<HibernateMapping> add)
         }
     }
 
-    private void BuildSingleMapping(Action<HibernateMapping> add)
+    void BuildSingleMapping(Action<HibernateMapping> add)
     {
         var hbm = new HibernateMapping();
 
@@ -207,13 +208,13 @@ private void BuildSingleMapping(Action<HibernateMapping> add)
             add(hbm);
     }
 
-    private void ApplyVisitors(IEnumerable<HibernateMapping> mappings)
+    void ApplyVisitors(IEnumerable<HibernateMapping> mappings)
     {
         foreach (var visitor in visitors)
             visitor.Visit(mappings);
     }
 
-    private void EnsureMappingsBuilt()
+    void EnsureMappingsBuilt()
     {
         if (compiledMappings is not null) return;
 
@@ -225,7 +226,7 @@ protected virtual string GetMappingFileName()
         return "FluentMappings.hbm.xml";
     }
 
-    private string DetermineMappingFileName(HibernateMapping mapping)
+    string DetermineMappingFileName(HibernateMapping mapping)
     {
         if (MergeMappings)
             return GetMappingFileName();
@@ -246,7 +247,7 @@ public void WriteMappingsTo(TextWriter writer)
         WriteMappingsTo( _ => new XmlTextWriter(writer), false);
     }
 
-    private void WriteMappingsTo(Func<HibernateMapping, XmlTextWriter> writerBuilder, bool shouldDispose)
+    void WriteMappingsTo(Func<HibernateMapping, XmlTextWriter> writerBuilder, bool shouldDispose)
     {
         EnsureMappingsBuilt();
 

src/FluentNHibernate/SessionSource.cs

@@ -19,7 +19,7 @@ public interface ISessionSource
 
 public class SessionSource : ISessionSource
 {
-    private Dialect dialect;
+    Dialect dialect;
     public Configuration Configuration { get; private set; }
     public ISessionFactory SessionFactory { get; private set; }
 

src/FluentNHibernate/Testing/PersistenceSpecification.cs

@@ -9,9 +9,9 @@ namespace FluentNHibernate.Testing;
 public class PersistenceSpecification<T>
 {
     protected readonly List<Property<T>> allProperties = new List<Property<T>>();
-    private readonly ISession currentSession;
-    private readonly IEqualityComparer entityEqualityComparer;
-    private readonly bool hasExistingTransaction;
+    readonly ISession currentSession;
+    readonly IEqualityComparer entityEqualityComparer;
+    readonly bool hasExistingTransaction;
 
     public PersistenceSpecification(ISessionSource source)
         : this(source.CreateSession())

src/FluentNHibernate/Testing/Values/List.cs

@@ -9,7 +9,7 @@ namespace FluentNHibernate.Testing.Values;
 public class List<T, TListElement>(Accessor property, IEnumerable<TListElement> value)
     : Property<T, IEnumerable<TListElement>>(property, value)
 {
-    private Action<T, Accessor, IEnumerable<TListElement>> _valueSetter;
+    Action<T, Accessor, IEnumerable<TListElement>> _valueSetter;
 
     public override Action<T, Accessor, IEnumerable<TListElement>> ValueSetter
     {
@@ -56,7 +56,7 @@ public override void CheckValue(object target)
         AssertGenericListMatches(actual, Expected);
     }
 
-    private void AssertGenericListMatches(IEnumerable actualEnumerable, IEnumerable<TListElement> expectedEnumerable)
+    void AssertGenericListMatches(IEnumerable actualEnumerable, IEnumerable<TListElement> expectedEnumerable)
     {
         if (actualEnumerable is null)
         {