Use golangci-lint action and update linters (#34)

Author: lucacome

.github/workflows/cicd.yml

@@ -16,24 +16,23 @@ on:
 
 jobs:
   checks:
-    name: Formatting and Linting
-    runs-on: ubuntu-20.04
+    name: Linting
+    runs-on: ubuntu-22.04
     steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
       - name: Setup Golang Environment
         uses: actions/setup-go@v3
         with:
-          go-version: '1.15'
-      - name: Checkout code
-        uses: actions/checkout@v3
-      - name: Lint code
-        run: |
-          make init
-          make fmt
-          make lint
+          go-version-file: go.mod
+      - name: Lint Code
+        uses: golangci/golangci-lint-action@v3
+        with:
+          only-new-issues: true
 
   unit-tests:
     name: Unit Tests
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     needs: checks
     steps:
       - name: Checkout Repository

.github/workflows/release.yml

@@ -7,7 +7,7 @@ on:
 
 jobs:
   release:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v2
 

.golangci.yml

@@ -25,6 +25,11 @@ linters:
     - golint
     - maligned
     - scopelint
+    # deprecated
+    - deadcode
+    - varcheck
+    - structcheck
+    - nosnakecase
 
 
 # Run options

Makefile

@@ -34,27 +34,30 @@ deps-upgrade:
 #######################################
 ## Tests, codegen, lint and format.
 #######################################
-fmt: $(info Running goimports...)
+fmt:
+	$(info Running goimports...)
 	@goimports -w -e $$(find . -type f -name '*.go' -not -path "./vendor/*")
 
-test: $(info Running unit tests...)
+test:
+	$(info Running unit tests...)
 	mkdir -p $(RESULTS_DIR)
 	CGO_ENABLED=1 go test -race -v -cover ./... -coverprofile=$(RESULTS_DIR)/$(PACKAGE)-coverage.out 2>&1 | tee >(go-junit-report > $(RESULTS_DIR)/report.xml)
 	@echo "Total code coverage:"
 	@go tool cover -func=$(RESULTS_DIR)/$(PACKAGE)-coverage.out | grep 'total:' | tee $(RESULTS_DIR)/anybadge.out
 	@go tool cover -html=$(RESULTS_DIR)/$(PACKAGE)-coverage.out -o $(RESULTS_DIR)/coverage.html
 
-test-only-failed: $(info Running unit tests (showing only failed ones with context)...)
+test-only-failed:
+	$(info Running unit tests (showing only failed ones with context)...)
 	go test -v -race ./... | grep --color -B 45 -A 5 -E '^FAIL.+'
 
 $(LINT_BIN):
-	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.36.0
+	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.51.2
 
 lint: $(LINT_BIN)
 	$(LINT_BIN) run
 
 lint-docker:
-	docker run --rm -v "${PWD}":/app -w /app golangci/golangci-lint:v1.36.0 golangci-lint run
+	docker run --rm -v "${PWD}":/app -w /app golangci/golangci-lint:v1.51.2 golangci-lint run
 
 lint-shell:
 	shellcheck -x $$(find . -name "*.sh" -type f -not -path "./vendor/*")