fix idempotency and add test

Author: aknot242

molecule/default/prepare.yml

@@ -41,7 +41,7 @@
             path: "/install/controller-agent"
           httpResponse:
             statusCode: 200
-            body: "echo 'hello'"
+            body: "mkdir /var/log/nginx-controller && touch /var/log/nginx-controller/agent.log"
 
         status_code: 201
         body_format: json

molecule/default/verify.yml

@@ -22,11 +22,20 @@
 - name: Verify File
   hosts: instances
   tasks:
-    - name: store the statistics of /etc/nginx/conf.d/nginx-plus-api.conf in the 'out' variable
+    - name: Store the statistics of /etc/nginx/conf.d/nginx-plus-api.conf in the 'conf_file' variable
       stat:
         path: /etc/nginx/conf.d/nginx-plus-api.conf
-      register: out
+      register: conf_file
 
     - name: Ensure /etc/nginx/conf.d/nginx-plus-api.conf exists
       assert:
-        that: out.stat.exists == true
+        that: conf_file.stat.exists == true
+
+    - name: Store the statistics of /var/log/nginx-controller/agent.log in the 'agent_log_file' variable
+      stat:
+        path: /var/log/nginx-controller/agent.log
+      register: agent_log_file
+
+    - name: Ensure /var/log/nginx-controller/agent.log exists
+      assert:
+        that: agent_log_file.stat.exists == true

tasks/main.yml

@@ -6,7 +6,7 @@
     - nginx_controller_fqdn
     - nginx_controller_api_key
 
-- name: COPY files/nginx-plus-api.conf /etc/nginx/conf.d/ necessary for process monitoring.
+- name: Copy files/nginx-plus-api.conf to /etc/nginx/conf.d/ necessary for process monitoring
   copy:
     src: "files/nginx-plus-api.conf"
     dest: "/etc/nginx/conf.d/nginx-plus-api.conf"
@@ -19,6 +19,7 @@
     dest: "{{ ansible_env.HOME }}/install.sh"
     validate_certs: "{{ nginx_controller_validate_certs | default(false) }}"
     force: true
+  changed_when: false
   register: nginx_controller_return
 
 - name: Run the NGINX Controller agent installer
@@ -32,13 +33,15 @@
   args:
     chdir: "{{ ansible_env.HOME }}"
     creates: /var/log/nginx-controller/agent.log
+  changed_when: false
   register: nginx_controller_agent_install
 
 - name: Output agent install results
   debug:
     var: nginx_controller_agent_install.stdout_lines
 
-- name: remove the install script
+- name: Remove the install script
   file:
     path: "{{ ansible_env.HOME }}/install.sh"
     state: absent
+  changed_when: false