Use default values when not provided

Author: Rulox

cmd/sync/aws.go

@@ -69,8 +69,8 @@ func (client *AWSClient) GetUpstreams() []Upstream {
 			ScalingGroup: client.config.Upstreams[i].AutoscalingGroup,
 			MaxConns:     &client.config.Upstreams[i].MaxConns,
 			MaxFails:     &client.config.Upstreams[i].MaxFails,
-			FailTimeout:  client.config.Upstreams[i].FailTimeout,
-			SlowStart:    client.config.Upstreams[i].SlowStart,
+			FailTimeout:  getFailTimeoutOrDefault(client.config.Upstreams[i].FailTimeout),
+			SlowStart:    getSlowStartOrDefault(client.config.Upstreams[i].SlowStart),
 		}
 		upstreams = append(upstreams, u)
 	}
@@ -167,7 +167,7 @@ func (client *AWSClient) GetPrivateIPsForScalingGroup(name string) ([]string, er
 
 type awsConfig struct {
 	Region    string
-	Upstreams []*awsUpstream
+	Upstreams []awsUpstream
 }
 
 type awsUpstream struct {

cmd/sync/aws_test.go

@@ -8,7 +8,7 @@ type testInputAWS struct {
 }
 
 func getValidAWSConfig() *awsConfig {
-	upstreams := []*awsUpstream{
+	upstreams := []awsUpstream{
 		{
 			Name:             "backend1",
 			AutoscalingGroup: "backend-group",
@@ -92,21 +92,21 @@ func TestValidateAWSConfigValid(t *testing.T) {
 
 func TestGetUpstreamsAWS(t *testing.T) {
 	cfg := getValidAWSConfig()
-	var upstreams = []*awsUpstream{
+	var upstreams = []awsUpstream{
 		{
-			Name: "127.0.0.1",
-			Port: 80,
-			MaxFails: 1,
-			MaxConns: 2,
-			SlowStart: "5s",
+			Name:        "127.0.0.1",
+			Port:        80,
+			MaxFails:    1,
+			MaxConns:    2,
+			SlowStart:   "5s",
 			FailTimeout: "10s",
 		},
 		{
-			Name: "127.0.0.2",
-			Port: 80,
-			MaxFails: 2,
-			MaxConns: 3,
-			SlowStart: "6s",
+			Name:        "127.0.0.2",
+			Port:        80,
+			MaxFails:    2,
+			MaxConns:    3,
+			SlowStart:   "6s",
 			FailTimeout: "11s",
 		},
 	}
@@ -131,7 +131,7 @@ func TestGetUpstreamsAWS(t *testing.T) {
 	}
 }
 
-func areEqualUpstreamsAWS(u1 *awsUpstream, u2 Upstream) bool {
+func areEqualUpstreamsAWS(u1 awsUpstream, u2 Upstream) bool {
 	if u1.Port != u2.Port {
 		return false
 	}
@@ -153,4 +153,4 @@ func areEqualUpstreamsAWS(u1 *awsUpstream, u2 Upstream) bool {
 	}
 
 	return true
-}
+}

cmd/sync/azure.go

@@ -138,8 +138,8 @@ func (client *AzureClient) GetUpstreams() []Upstream {
 			ScalingGroup: client.config.Upstreams[i].VMScaleSet,
 			MaxConns:     &client.config.Upstreams[i].MaxConns,
 			MaxFails:     &client.config.Upstreams[i].MaxFails,
-			FailTimeout:  client.config.Upstreams[i].FailTimeout,
-			SlowStart:    client.config.Upstreams[i].SlowStart,
+			FailTimeout:  getFailTimeoutOrDefault(client.config.Upstreams[i].FailTimeout),
+			SlowStart:    getSlowStartOrDefault(client.config.Upstreams[i].SlowStart),
 		}
 		upstreams = append(upstreams, u)
 	}
@@ -149,7 +149,7 @@ func (client *AzureClient) GetUpstreams() []Upstream {
 type azureConfig struct {
 	SubscriptionID    string `yaml:"subscription_id"`
 	ResourceGroupName string `yaml:"resource_group_name"`
-	Upstreams         []*azureUpstream
+	Upstreams         []azureUpstream
 }
 
 type azureUpstream struct {

cmd/sync/azure_test.go

@@ -12,7 +12,7 @@ type testInputAzure struct {
 }
 
 func getValidAzureConfig() *azureConfig {
-	upstreams := []*azureUpstream{
+	upstreams := []azureUpstream{
 		{
 			Name:       "backend1",
 			VMScaleSet: "backend-group",
@@ -159,21 +159,21 @@ func TestGetPrimaryIPFromInterfaceIPConfigurationFail(t *testing.T) {
 
 func TestGetUpstreamsAzure(t *testing.T) {
 	cfg := getValidAzureConfig()
-	var upstreams = []*azureUpstream{
+	var upstreams = []azureUpstream{
 		{
-			Name: "127.0.0.1",
-			Port: 80,
-			MaxFails: 1,
-			MaxConns: 2,
-			SlowStart: "5s",
+			Name:        "127.0.0.1",
+			Port:        80,
+			MaxFails:    1,
+			MaxConns:    2,
+			SlowStart:   "5s",
 			FailTimeout: "10s",
 		},
 		{
-			Name: "127.0.0.2",
-			Port: 80,
-			MaxFails: 2,
-			MaxConns: 3,
-			SlowStart: "6s",
+			Name:        "127.0.0.2",
+			Port:        80,
+			MaxFails:    2,
+			MaxConns:    3,
+			SlowStart:   "6s",
 			FailTimeout: "11s",
 		},
 	}
@@ -198,7 +198,7 @@ func TestGetUpstreamsAzure(t *testing.T) {
 	}
 }
 
-func areEqualUpstreamsAzure(u1 *azureUpstream, u2 Upstream) bool {
+func areEqualUpstreamsAzure(u1 azureUpstream, u2 Upstream) bool {
 	if u1.Port != u2.Port {
 		return false
 	}
@@ -220,4 +220,4 @@ func areEqualUpstreamsAzure(u1 *azureUpstream, u2 Upstream) bool {
 	}
 
 	return true
-}
+}

cmd/sync/parameters.go

@@ -0,0 +1,20 @@
+package main
+
+const defaultFailTimeout = "10s"
+const defaultSlowStart = "0s"
+
+func getFailTimeoutOrDefault(failTimeout string) string {
+	if failTimeout == "" {
+		return defaultFailTimeout
+	}
+
+	return failTimeout
+}
+
+func getSlowStartOrDefault(slowStart string) string {
+	if slowStart == "" {
+		return defaultSlowStart
+	}
+
+	return slowStart
+}

cmd/sync/parameters_test.go

@@ -0,0 +1,51 @@
+package main
+
+import (
+	"testing"
+)
+
+func TestGetFailTimeoutOrDefault(t *testing.T) {
+	tests := []struct{
+		input string
+		expected string
+	}{
+		{
+			input: "",
+			expected: defaultFailTimeout,
+		},
+		{
+			input: "10s",
+			expected: "10s",
+		},
+	}
+
+	for _, test := range tests {
+		result := getFailTimeoutOrDefault(test.input)
+		if result != test.expected {
+			t.Errorf("getFailTimeoutOrDefault(%v) returned %v but expected %v", test.input, result, test.expected)
+		}
+	}
+}
+
+func TestGetSlowStartOrDefault(t *testing.T) {
+	tests := []struct{
+		input string
+		expected string
+	}{
+		{
+			input: "",
+			expected: defaultSlowStart,
+		},
+		{
+			input: "10s",
+			expected: "10s",
+		},
+	}
+
+	for _, test := range tests {
+		result := getSlowStartOrDefault(test.input)
+		if result != test.expected {
+			t.Errorf("getSlowStartOrDefault(%v) returned %v but expected %v", test.input, result, test.expected)
+		}
+	}
+}