-
Notifications
You must be signed in to change notification settings - Fork 122
Docs: add missing prerequisite for installation #1485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
✅ Deploy Preview will be available once build job completes!
|
|
I have hereby read the F5 CLA and agree to its terms |
d366350 to
dc87dc4
Compare
c0adb94 to
d54baa0
Compare
d54baa0 to
9f5a581
Compare
JTorreG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a TODO label
Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
dfc4c24 to
04698aa
Compare
ADubhlaoich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM: approval pending feedback.
Please run the linting tools on this branch, which can be executed automatically with pre-commit.
| - [Docker]({{< ref "/waf/install/docker.md#before-you-begin" >}}) | ||
| - [Kubernetes]({{< ref "/waf/install/kubernetes.md#before-you-begin" >}}) | ||
| - An active F5 WAF for NGINX subscription (Purchased or trial). | ||
| - Active F5 NGINX App Protect WAF subscription in [MyF5](https://my.f5.com/manage/s/) (purchased or trial) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Active F5 NGINX App Protect WAF subscription in [MyF5](https://my.f5.com/manage/s/) (purchased or trial) | |
| - An active F5 WAF for NGINX subscription (Available from [MyF5](https://my.f5.com/manage/s/)) |
This is not the product name: it is "F5 WAF for NGINX".
content/waf/install/docker.md
Outdated
|
|
||
| - An active F5 WAF for NGINX subscription (Purchased or trial) | ||
| - [Docker](https://docs.docker.com/get-started/get-docker/) | ||
| - Active F5 NGINX App Protect WAF subscription in [MyF5](https://my.f5.com/manage/s/) (purchased or trial) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Active F5 NGINX App Protect WAF subscription in [MyF5](https://my.f5.com/manage/s/) (purchased or trial) | |
| - An active F5 WAF for NGINX subscription (Available from [MyF5](https://my.f5.com/manage/s/)) |
This is not the product name: it is "F5 WAF for NGINX".
content/waf/install/docker.md
Outdated
| The steps you should follow on this page are dependent on your configuration type: after the shared steps, links will guide you to the next appropriate section. | ||
|
|
||
| ## Download your subscription credentials | ||
| ### Shared Requirements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### Shared Requirements | |
| ### Shared requirements |
This is title case, not sentence case.
content/waf/install/docker.md
Outdated
|
|
||
| {{< include "licensing-and-reporting/download-certificates-from-myf5.md" >}} | ||
|
|
||
| ### Additional Requirement for NGINX Plus Users |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### Additional Requirement for NGINX Plus Users | |
| ### Additional requirements for NGINX Plus |
This is title case, not sentence case.
| You should read the [IP intelligence]({{< ref "/waf/policies/ip-intelligence.md" >}}) and [Secure traffic using mTLS]({{< ref "/waf/configure/secure-mtls.md" >}}) topics for additional set-up configuration if you want to use them immediately. | ||
|
|
||
| {{< include "waf/install-selinux-warning.md" >}} | ||
| ### Required: Download JWT License for NGINX Plus Installation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### Required: Download JWT License for NGINX Plus Installation | |
| ### Download JWT license for NGINX Plus |
This is title case, not sentence case.
Proposed changes
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩