Merge pull request #49 from nginxinc/(bug)/fix-modules

Refactor and fix module installation

Author: alessfg

tasks/main.yml

@@ -14,26 +14,8 @@
     - import_tasks: plus/install-plus.yml
       when: type == "plus"
 
-    - import_tasks: modules/install-njs.yml
-      when: modules.njs
-
-    - import_tasks: modules/install-perl.yml
-      when: modules.perl
-
-    - import_tasks: modules/install-geoip.yml
-      when: modules.geoip
-
-    - import_tasks: modules/install-image-filter.yml
-      when: modules.image_filter
-
-    - import_tasks: modules/install-rtmp.yml
-      when: modules.rtmp
-
-    - import_tasks: modules/install-xslt.yml
-      when: modules.xslt
-
-    - import_tasks: modules/install-waf.yml
-      when: modules.waf and type == "plus"
+    - import_tasks: modules/install-modules.yml
+      when: true in modules.values()
 
     - import_tasks: conf/push-config.yml
       when: main_push_enable or http_push_enable or stream_push_enable

tasks/modules/install-geoip.yml

@@ -1,13 +1,13 @@
 ---
 - name: "(Install: All OSs) Install NGINX Open Source GeoIP Module"
   package:
-    name: nginx-geoip-perl
+    name: nginx-module-geoip
     state: present
   when: type == "opensource"
 
 - name: "(Install: All OSs) Install NGINX Plus GeoIP Module"
   package:
-    name: nginx-plus-geoip-perl
+    name: nginx-plus-module-geoip
     state: present
   when: type == "plus"
 

tasks/modules/install-modules.yml

@@ -0,0 +1,21 @@
+---
+- import_tasks: install-njs.yml
+  when: modules.njs | default(false)
+
+- import_tasks: install-perl.yml
+  when: modules.perl | default(false)
+
+- import_tasks: install-geoip.yml
+  when: modules.geoip | default(false)
+
+- import_tasks: install-image-filter.yml
+  when: modules.image_filter | default(false)
+
+- import_tasks: install-rtmp.yml
+  when: modules.rtmp | default(false)
+
+- import_tasks: install-xslt.yml
+  when: modules.xslt | default(false)
+
+- import_tasks: install-waf.yml
+  when: modules.waf | default(false) and type == "plus"