-
Notifications
You must be signed in to change notification settings - Fork 100
Retry request if no response is sent by management plane #1381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1381 +/- ##
==========================================
+ Coverage 86.31% 86.32% +0.01%
==========================================
Files 102 102
Lines 12603 12617 +14
==========================================
+ Hits 10878 10892 +14
Misses 1249 1249
Partials 476 476
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| ) { | ||
| slog.DebugContext(ctx, "Create connection request", "request", request) | ||
|
|
||
| if !cs.firstConnectionCallFlag { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment here explaining why we are doing this?
Proposed changes
Added
response_timeoutto agent config underclient_grpc-> Default is 10 secondsUse
response_timeoutwhen making request to management plane, if no response is received in the set time resend the response.Modified the mock management plane so the first create connection request is ignored to test the retry logic in the integration tests.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)