Skip to content

Conversation

@aphralG
Copy link
Contributor

@aphralG aphralG commented Nov 10, 2025

Proposed changes

Added response_timeout to agent config under client_grpc -> Default is 10 seconds
Use response_timeout when making request to management plane, if no response is received in the set time resend the response.
Modified the mock management plane so the first create connection request is ignored to test the retry logic in the integration tests.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Nov 10, 2025
@aphralG aphralG requested a review from a team as a code owner November 10, 2025 13:48
@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 10, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.32%. Comparing base (b1947ec) to head (41f9856).

Files with missing lines Patch % Lines
internal/command/command_service.go 83.33% 2 Missing ⚠️
internal/file/file_service_operator.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1381      +/-   ##
==========================================
+ Coverage   86.31%   86.32%   +0.01%     
==========================================
  Files         102      102              
  Lines       12603    12617      +14     
==========================================
+ Hits        10878    10892      +14     
  Misses       1249     1249              
  Partials      476      476              
Files with missing lines Coverage Δ
internal/config/config.go 87.37% <100.00%> (+0.07%) ⬆️
internal/config/defaults.go 100.00% <ø> (ø)
internal/config/flags.go 100.00% <ø> (ø)
internal/config/types.go 87.65% <ø> (ø)
internal/file/file_service_operator.go 76.29% <75.00%> (+0.15%) ⬆️
internal/command/command_service.go 80.74% <83.33%> (+0.36%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1947ec...41f9856. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

) {
slog.DebugContext(ctx, "Create connection request", "request", request)

if !cs.firstConnectionCallFlag {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here explaining why we are doing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants