Skip to content

Fix CI: Ensure confirm-pass job runs for markdown-only PRs #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 25, 2025
Merged

Fix CI: Ensure confirm-pass job runs for markdown-only PRs #1618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
640d7dd
Fix CI: Ensure confirm-pass job runs for markdown-only PRs
pinin4fjords Nov 13, 2025
1148f65
Update CHANGELOG.md for PR #1618
pinin4fjords Nov 13, 2025
5b8e22b
Trigger CI
pinin4fjords Nov 13, 2025
7081d5e
Fix paths-filter to use 'every' quantifier
pinin4fjords Nov 13, 2025
659580e
Prettier
pinin4fjords Nov 13, 2025
96b3d05
Don't lint CI
pinin4fjords Nov 13, 2025
a1dbd8a
Fix ci exclusion
pinin4fjords Nov 13, 2025
72faa29
TEST COMMIT: Trigger nf-test workflow (will revert)
pinin4fjords Nov 13, 2025
bc00d8c
Revert "TEST COMMIT: Trigger nf-test workflow (will revert)"
pinin4fjords Nov 13, 2025
47a84d9
Merge branch 'dev' into fix-ci-confirm-pass-markdown-prs
pinin4fjords Nov 14, 2025
e6bb184
ci: Skip tests if there's not shards
edmundmiller Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .github/workflows/nf-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
name: Run nf-test
on:
pull_request:
paths-ignore:
- "docs/**"
- "**/meta.yml"
- "**/*.md"
- "**/*.png"
- "**/*.svg"
Comment on lines -4 to -9
Copy link
Contributor

@edmundmiller edmundmiller Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you're changing this?

Copy link
Contributor

@edmundmiller edmundmiller Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see now.

Let's remove the' paths-ignore' part and the on: file-specific sections if that's not working for your docs PRs.

The reason we did that was to avoid spinning up a job just to check on those, but it makes sense if you're running into an actual CI requirement, and because this is RNAseq.

release:
types: [published]
workflow_dispatch:
Expand Down Expand Up @@ -121,7 +115,7 @@ jobs:
fi

confirm-pass:
needs: [nf-test]
needs: [nf-test-changes, nf-test]
if: always()
runs-on: # use self-hosted runners
- runs-on=${{ github.run_id }}-confirm-pass
Expand All @@ -142,7 +136,7 @@ jobs:
- name: debug-print
if: always()
run: |
echo "::group::DEBUG: `needs` Contents"
echo "::group::DEBUG: needs Contents"
echo "DEBUG: toJSON(needs) = ${{ toJSON(needs) }}"
echo "DEBUG: toJSON(needs.*.result) = ${{ toJSON(needs.*.result) }}"
echo "::endgroup::"
1 change: 1 addition & 0 deletions .nf-core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
lint:
actions_nf_test: false
files_exist:
- conf/modules.config
files_unchanged:
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Special thanks to the following for their contributions to the release:
### Enhancements and fixes

- [PR #1608](https://github.com/nf-core/rnaseq/pull/1608) - Bump version after release 3.21.0
- [PR #1618](https://github.com/nf-core/rnaseq/pull/1618) - Fix CI: Ensure confirm-pass job runs for markdown-only PRs
- [PR #1617](https://github.com/nf-core/rnaseq/pull/1617) - Update bbmap/bbsplit module

## [[3.21.0](https://github.com/nf-core/rnaseq/releases/tag/3.21.0)] - 2025-09-18
Expand Down