Simplify plugin download implementation (#6349) [ci fast]

* Simplify plugin download implementation

- Remove OciAwareFileDownloader class and use SimpleFileDownloader instead
- Remove unnecessary file renaming logic in PluginUpdater
- Streamline plugin download process by removing complex OCI authentication

This simplifies the plugin download mechanism while maintaining core functionality.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Remove deprecated OCI downloader

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>

* Remove deprecated test

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>

---------

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

Author: pditommaso

modules/nf-commons/src/main/nextflow/plugin/HttpPluginRepository.groovy

@@ -17,6 +17,7 @@ import org.pf4j.update.FileDownloader
 import org.pf4j.update.FileVerifier
 import org.pf4j.update.PluginInfo
 import org.pf4j.update.PluginInfo.PluginRelease
+import org.pf4j.update.SimpleFileDownloader
 import org.pf4j.update.verifier.CompoundVerifier
 /**
  * Represents an update repository served via an HTTP api.
@@ -99,7 +100,7 @@ class HttpPluginRepository implements PrefetchUpdateRepository {
 
     @Override
     FileDownloader getFileDownloader() {
-        return new OciAwareFileDownloader()
+        return new SimpleFileDownloader()
     }
 
     @Override

modules/nf-commons/src/main/nextflow/plugin/OciAwareFileDownloader.groovy

@@ -239,18 +239,11 @@ class PluginUpdater extends UpdateManager {
         // 2. download to temporary location
         Path downloaded = safeDownloadPlugin(id, version);
 
-        // 3. rename to match the expected name
-        if ( downloaded.getFileName().toString() != "${pluginPath.getFileName()}.zip" ) {
-            final targetName = downloaded.resolveSibling("${pluginPath.getFileName()}.zip")
-            if ( !Files.move(downloaded, targetName) ) throw new PluginRuntimeException("Failed to rename '$downloaded'")
-            downloaded = targetName
-        }
-
-        // 4. unzip the content and delete downloaded file
+        // 3. unzip the content and delete downloaded file
         Path dir = FileUtils.expandIfZip(downloaded)
         FileHelper.deletePath(downloaded)
 
-        // 5. move the final destination the plugin directory
+        // 4. move the final destination the plugin directory
         assert pluginPath.getFileName() == dir.getFileName()
         try {
             safeMove(dir, pluginPath)