Avoid iterating files when --exact is passed in

This fixes a quadratic performance issue in which the test directories are iterated for every test
case when run under nextest.

Author: zaneduffield

src/runner.rs

@@ -11,8 +11,7 @@ use libtest_mimic::{Arguments, Trial};
 pub fn runner(requirements: &[Requirements]) -> ExitCode {
     let args = Arguments::from_args();
 
-    let mut tests: Vec<_> = requirements.iter().flat_map(|req| req.expand()).collect();
-    tests.sort_unstable_by(|a, b| a.name().cmp(b.name()));
+    let tests = find_tests(&args, requirements);
 
     let conclusion = libtest_mimic::run(&args, tests);
 
@@ -25,6 +24,59 @@ pub fn runner(requirements: &[Requirements]) -> ExitCode {
     conclusion.exit_code()
 }
 
+fn find_tests(args: &Arguments, requirements: &[Requirements]) -> Vec<Trial> {
+    let tests: Vec<_> = if let Some(exact_filter) = exact_filter(args) {
+        let exact_tests: Vec<_> = requirements
+            .iter()
+            .flat_map(|req| req.exact(exact_filter))
+            .collect();
+
+        if is_nextest() {
+            if exact_tests.is_empty() {
+                panic!("Failed to find exact match for filter {exact_filter}");
+            } else if exact_tests.len() > 1 {
+                panic!(
+                    "Only expected one but found {} exact matches for filter {exact_filter}",
+                    exact_tests.len()
+                );
+            }
+        }
+        exact_tests
+    } else if is_full_scan_forbidden() {
+        panic!("Exact filter was expected to be used");
+    } else {
+        let mut tests: Vec<_> = requirements.iter().flat_map(|req| req.expand()).collect();
+        tests.sort_unstable_by(|a, b| a.name().cmp(b.name()));
+        tests
+    };
+    tests
+}
+
+fn is_nextest() -> bool {
+    std::env::var_os("NEXTEST")
+        .filter(|var| var == "1")
+        .is_some()
+}
+
+fn is_full_scan_forbidden() -> bool {
+    #[cfg(test)]
+    {
+        std::env::var_os("DATATEST_FULL_SCAN_FORBIDDEN")
+            .filter(|var| var == "1")
+            .is_some()
+    }
+    #[cfg(not(test))]
+    false
+}
+
+fn exact_filter(args: &Arguments) -> Option<&str> {
+    if args.exact && args.skip.is_empty() {
+        args.filter.as_deref()
+    } else {
+        None
+    }
+}
+
 #[doc(hidden)]
 pub struct Requirements {
     test: TestFn,
@@ -49,6 +101,25 @@ impl Requirements {
         }
     }
 
+    fn trial(&self, path: Utf8PathBuf) -> Trial {
+        let testfn = self.test;
+        let name = utils::derive_test_name(&self.root, &path, &self.test_name);
+        Trial::test(name, move || {
+            testfn
+                .call(&path)
+                .map_err(|err| format!("{:?}", err).into())
+        })
+    }
+
+    fn exact(&self, filter: &str) -> Option<Trial> {
+        let path = utils::derive_test_path(&self.root, filter, &self.test_name)?;
+        if path.exists() {
+            Some(self.trial(path))
+        } else {
+            None
+        }
+    }
+
     /// Scans all files in a given directory, finds matching ones and generates a test descriptor
     /// for each of them.
     fn expand(&self) -> Vec<Trial> {
@@ -66,13 +137,7 @@ impl Requirements {
                         error
                     )
                 }) {
-                    let testfn = self.test;
-                    let name = utils::derive_test_name(&self.root, &path, &self.test_name);
-                    Some(Trial::test(name, move || {
-                        testfn
-                            .call(&path)
-                            .map_err(|err| format!("{:?}", err).into())
-                    }))
+                    Some(self.trial(path))
                 } else {
                     None
                 }

src/utils.rs

@@ -33,3 +33,76 @@ pub fn derive_test_name(root: &Utf8Path, path: &Utf8Path, test_name: &str) -> St
 
     format!("{}::{}", test_name, relative)
 }
+
+pub fn derive_test_path(root: &Utf8Path, filter: &str, test_name: &str) -> Option<Utf8PathBuf> {
+    let relative = filter.strip_prefix(test_name)?.strip_prefix("::")?;
+    Some(root.join(relative))
+}
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    mod derive_path {
+        use super::*;
+
+        #[test]
+        fn missing_test_name() {
+            assert_eq!(derive_test_path("root".into(), "file", "test_name"), None);
+        }
+
+        #[test]
+        fn missing_colons() {
+            assert_eq!(
+                derive_test_path("root".into(), "test_name", "test_name"),
+                None
+            );
+        }
+
+        #[test]
+        fn is_relative_to_root() {
+            assert_eq!(
+                derive_test_path("root".into(), "test_name::file", "test_name"),
+                Some("root/file".into())
+            );
+            assert_eq!(
+                derive_test_path("root2".into(), "test_name::file", "test_name"),
+                Some("root2/file".into())
+            );
+        }
+
+        #[test]
+        fn nested_dirs() {
+            assert_eq!(
+                derive_test_path("root".into(), "test_name::dir/dir2/file", "test_name"),
+                Some("root/dir/dir2/file".into())
+            );
+        }
+
+        #[test]
+        fn subsequent_module_separators_remain() {
+            assert_eq!(
+                derive_test_path("root".into(), "test_name::mod::file", "test_name"),
+                Some("root/mod::file".into())
+            );
+        }
+
+        #[test]
+        fn inverse_of_derive_test_name() {
+            let root: Utf8PathBuf = "root".into();
+            for (path, test_name) in [
+                (root.join("foo/bar.txt"), "test_name"),
+                (root.join("foo::bar.txt"), "test_name"),
+                (root.join("foo/bar/baz"), "test_name"),
+                (root.join("foo"), "test_name::mod"),
+                (root.join("🦀"), "🚀::🚀"),
+            ] {
+                let derived_test_name = derive_test_name(&root, &path, test_name);
+                assert_eq!(
+                    derive_test_path(&root, &derived_test_name, test_name),
+                    Some(path)
+                );
+            }
+        }
+    }
+}

tests/files/::colon::dir/::.txt

@@ -0,0 +1 @@
+floop

tests/files/::colon::dir/a.txt

@@ -0,0 +1 @@
+flarp