Merge pull request #1595 from nextcloud/fix/prevent-exception-for-share-a-file-by-inviting-a-new-guest-account

Prevent exception for a share file by inviting a new guest account

Author: JuliaKirschenheuter

lib/AppInfo/BeforeShareCreatedListener.php

@@ -14,6 +14,7 @@
 use OCP\EventDispatcher\Event;
 use OCP\EventDispatcher\IEventListener;
 use OCP\Files\File;
+use OCP\IUserManager;
 use OCP\Share\Events\BeforeShareCreatedEvent;
 use OCP\Share\IShare;
 use Psr\Log\LoggerInterface;
@@ -24,7 +25,12 @@ class BeforeShareCreatedListener implements IEventListener {
 	private NoteUtil $noteUtil;
 	private LoggerInterface $logger;
 
-	public function __construct(SettingsService $settings, NoteUtil $noteUtil, LoggerInterface $logger) {
+	public function __construct(
+		protected IUserManager $userManager,
+		SettingsService $settings,
+		NoteUtil $noteUtil,
+		LoggerInterface $logger,
+	) {
 		$this->settings = $settings;
 		$this->noteUtil = $noteUtil;
 		$this->logger = $logger;
@@ -63,6 +69,12 @@ public function overwriteShareTarget(IShare $share): void {
 
 			$share->setTarget('/' . $receiverNotesInternalPath . $itemTarget);
 		} catch (\Throwable $e) {
+			if (isset($receiver)) {
+				$user = $this->userManager->get($receiver);
+				if ($user && $user->getBackendClassName() === 'Guests') {
+					return;
+				}
+			}
 			$this->logger->error('Failed to overwrite share target for notes', [
 				'exception' => $e,
 			]);