Skip to content

Commit 8944561

Browse files
committed
Sidebar: removed
Signed-off-by: Jonathan Pagel <jonny_tischbein@systemli.org>
1 parent 28400c3 commit 8944561

File tree

7 files changed

+2
-286
lines changed

7 files changed

+2
-286
lines changed

src/App.vue

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@
4040
</div>
4141
</NcAppContent>
4242
<router-view v-else />
43-
44-
<router-view name="sidebar" />
4543
</NcContent>
4644
</template>
4745

src/components/NavigationNoteItem.vue

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,6 @@
1515
<NcActionButton :icon="actionFavoriteIcon" @click="onToggleFavorite">
1616
{{ actionFavoriteText }}
1717
</NcActionButton>
18-
<NcActionButton icon="icon-details" @click="onToggleSidebar">
19-
<SidebarIcon slot="icon" :size="20" />
20-
{{ t('notes', 'Details') }}
21-
</NcActionButton>
2218
<NcActionButton v-if="!note.readonly" :icon="actionDeleteIcon" @click="onDeleteNote">
2319
{{ t('notes', 'Delete note') }}
2420
</NcActionButton>
@@ -36,9 +32,7 @@ import {
3632
NcActionSeparator,
3733
NcAppNavigationItem,
3834
} from '@nextcloud/vue'
39-
import SidebarIcon from 'vue-material-design-icons/PageLayoutSidebarRight.vue'
4035
import { showError } from '@nextcloud/dialogs'
41-
import store from '../store.js'
4236
4337
import { setFavorite, setTitle, fetchNote, deleteNote } from '../NotesService.js'
4438
import { categoryLabel, routeIsNewNote } from '../Util.js'
@@ -50,7 +44,6 @@ export default {
5044
NcActionButton,
5145
NcActionSeparator,
5246
NcAppNavigationItem,
53-
SidebarIcon,
5447
},
5548
5649
props: {
@@ -124,11 +117,6 @@ export default {
124117
this.$emit('category-selected', this.note.category)
125118
},
126119
127-
onToggleSidebar() {
128-
this.actionsOpen = false
129-
store.commit('setSidebarOpen', !store.state.app.sidebarOpen)
130-
},
131-
132120
onRename(newTitle) {
133121
this.loading.note = true
134122
setTitle(this.note.id, newTitle)

src/components/NotePlain.vue

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<template>
2-
<NcAppContent :class="{ loading: loading || isManualSave, 'icon-error': !loading && (!note || note.error), 'sidebar-open': sidebarOpen }">
2+
<NcAppContent :class="{ loading: loading || isManualSave, 'icon-error': !loading && (!note || note.error)}">
33
<div v-if="!loading && note && !note.error && !note.deleting"
44
id="note-container"
55
class="note-container"
@@ -47,13 +47,6 @@
4747
</div>
4848
<span class="action-buttons">
4949
<NcActions :open.sync="actionsOpen" container=".action-buttons" menu-align="right">
50-
<NcActionButton v-show="!sidebarOpen && !fullscreen"
51-
icon="icon-details"
52-
@click="onToggleSidebar"
53-
>
54-
<SidebarIcon slot="icon" :size="20" />
55-
{{ t('notes', 'Details') }}
56-
</NcActionButton>
5750
<NcActionButton
5851
v-tooltip.left="t('notes', 'CTRL + /')"
5952
@click="onTogglePreview"
@@ -109,7 +102,6 @@ import EditIcon from 'vue-material-design-icons/LeadPencil.vue'
109102
import EyeIcon from 'vue-material-design-icons/Eye.vue'
110103
import FullscreenIcon from 'vue-material-design-icons/Fullscreen.vue'
111104
import NoEditIcon from 'vue-material-design-icons/PencilOff.vue'
112-
import SidebarIcon from 'vue-material-design-icons/PageLayoutSidebarRight.vue'
113105
import SyncAlertIcon from 'vue-material-design-icons/SyncAlert.vue'
114106
115107
import { config } from '../config.js'
@@ -133,7 +125,6 @@ export default {
133125
NcAppContent,
134126
NcModal,
135127
NoEditIcon,
136-
SidebarIcon,
137128
SyncAlertIcon,
138129
TheEditor,
139130
ThePreview,
@@ -179,9 +170,6 @@ export default {
179170
isManualSave() {
180171
return store.state.app.isManualSave
181172
},
182-
sidebarOpen() {
183-
return store.state.app.sidebarOpen
184-
},
185173
},
186174
187175
watch: {
@@ -293,11 +281,6 @@ export default {
293281
this.actionsOpen = false
294282
},
295283
296-
onToggleSidebar() {
297-
store.commit('setSidebarOpen', !store.state.app.sidebarOpen)
298-
this.actionsOpen = false
299-
},
300-
301284
onVisibilityChange() {
302285
if (document.visibilityState === 'visible') {
303286
this.stopRefreshTimer()
@@ -436,9 +419,6 @@ export default {
436419
transition-duration: var(--animation-quick);
437420
transition-property: padding-right;
438421
}
439-
.sidebar-open .note-container {
440-
padding-right: 0px;
441-
}
442422
}
443423
444424
/* distraction free styles */

src/components/NoteRich.vue

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<template>
2-
<NcAppContent :class="{ loading: loading, 'icon-error': !loading && (!note || note.error), 'sidebar-open': sidebarOpen, 'is-mobile': isMobile }">
2+
<NcAppContent :class="{ loading: loading, 'icon-error': !loading && (!note || note.error), 'is-mobile': isMobile }">
33
<div v-show="!loading" ref="editor" class="text-editor" />
44
</NcAppContent>
55
</template>
@@ -45,9 +45,6 @@ export default {
4545
isNewNote() {
4646
return routeIsNewNote(this.$route)
4747
},
48-
sidebarOpen() {
49-
return store.state.app.sidebarOpen
50-
},
5148
},
5249
5350
watch: {

src/components/Sidebar.vue

Lines changed: 0 additions & 239 deletions
This file was deleted.

src/router.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import { generateUrl } from '@nextcloud/router'
55
import Loading from './components/Loading.vue'
66
import Welcome from './components/Welcome.vue'
77
import Note from './components/Note.vue'
8-
import Sidebar from './components/Sidebar.vue'
98

109
Vue.use(Router)
1110

@@ -29,11 +28,9 @@ export default new Router({
2928
name: 'note',
3029
components: {
3130
default: Note,
32-
sidebar: Sidebar,
3331
},
3432
props: {
3533
default: true,
36-
sidebar: true,
3734
},
3835
},
3936
],

0 commit comments

Comments
 (0)